Skip to content

Documentation/ground clearance bb relation #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2021
Merged

Documentation/ground clearance bb relation #470

merged 4 commits into from
Feb 12, 2021

Conversation

PhRosenberger
Copy link
Contributor

@PhRosenberger PhRosenberger commented Jan 29, 2021 •
edited
Loading

Reference to a related issue in the repository

Resolves #467.

Add a description

Finetuning of the description of ground_clearance and its relation to the bounding box height.

Mention a member

Has been discussed with @kmeids and @pmai .

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@PhRosenberger PhRosenberger requested a review from kmeids January 29, 2021 18:39
@PhRosenberger PhRosenberger self-assigned this Jan 29, 2021
@PhRosenberger PhRosenberger force-pushed the documentation/ground-clearance_bb_relation branch 2 times, most recently from a69387f to 446cc34 Compare February 3, 2021 10:29
@PhRosenberger PhRosenberger requested a review from pmai February 3, 2021 10:44
kmeids
kmeids reviewed Feb 5, 2021
View reviewed changes
Copy link

@kmeids kmeids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side.
A documentation review by the service provider is to be done.
@max-rosin could you please take a look?

@kmeids kmeids added Documentation Everything which impacts the quality of the documentation and guidelines. Quality Quality improvements. labels Feb 5, 2021
@max-rosin
Copy link
Contributor

Reviewed documentation changes and simplified language a bit (remove brackets and abbreviations, split longer sentences).

@kmeids kmeids added ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. and removed Documentation Everything which impacts the quality of the documentation and guidelines. labels Feb 5, 2021
@kmeids kmeids added this to the V3.3.0 milestone Feb 11, 2021
kmeids
kmeids approved these changes Feb 11, 2021
View reviewed changes
Copy link

@kmeids kmeids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the CBB meeting 11.02.2021

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Feb 11, 2021
@kmeids
Copy link

kmeids commented Feb 11, 2021

Output from CCB meeting 11.02.2021:
Actions:

  1. @pmai please do the merge (permission to do the sign-off as well)

PhRosenberger and others added 4 commits February 12, 2021 14:11
@PhRosenberger @pmai
Tune definition of ground_clearance vs. bounding box
59ddd4d 
Update osi_detectedobject.proto, ground_clearance is included in base().height.

Signed-off-by: Philipp Rosenberger <[email protected]>
@PhRosenberger @pmai
Finetuning of ground clearance, resolves #467
66369fd 
Signed-off-by: Philipp Rosenberger <[email protected]>
@max-rosin @pmai
fix(docs): Review documentation changes (#467)
109128e 
Signed-off-by: Maximilian Rosin <[email protected]>
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Clarify ground_clearance reference to vehicle body
c7b7195 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai pmai force-pushed the documentation/ground-clearance_bb_relation branch from 685509e to c7b7195 Compare February 12, 2021 13:16
@pmai pmai merged commit d0ae8e4 into master Feb 12, 2021
@pmai pmai deleted the documentation/ground-clearance_bb_relation branch February 12, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmeids kmeids kmeids approved these changes

@pmai pmai Awaiting requested review from pmai

Assignees

@PhRosenberger PhRosenberger

Labels

Quality Quality improvements. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Milestone

V3.3.0

Development

Successfully merging this pull request may close these issues.

Clear Statement on Ground Clearance and Bounding Box needed?

4 participants

@PhRosenberger @max-rosin @kmeids @pmai