-
Notifications
You must be signed in to change notification settings - Fork 4
Fix tuple.value not set in OGTupleWithBuffer #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=====================================
Coverage 5.59% 5.60%
=====================================
Files 25 25
Lines 643 642 -1
=====================================
Hits 36 36
+ Misses 607 606 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nice catch up. Would you mind adding a test case to cover it?
|
Sorry for the late reply. I have ran the test locally, and when executing swift test --filter UnsafeMutableTupleCompatibilityTests
[1/1] Planning build
Building for debugging...
In file included from /Users/xxx/SwiftProjects/OpenSwiftUIProject/OpenGraph/Tests/OpenGraph_SPITests/table_test_case.mm:8:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCTest.h:35:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCUIAutomation.framework/Headers/XCUIAutomation.h:7:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCUIAutomation.framework/Headers/XCUIApplication.h:6:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCUIAutomation.framework/Headers/XCUIElement.h:10:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:15:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityColor.h:9:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSColor.h:46:
In file included from /Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:10:
/Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSResponder.h:376:4: error: expected a type
376 | - (IBAction)newWindowForTab:(nullable id)sender API_AVAILABLE(macos(10.12));
| ^
/Applications/Xcode-16.4.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSResponder.h:382:4: error: expected a type
382 | - (IBAction)showWritingTools:(nullable id)sender API_AVAILABLE(macos(15.2));
| ^
2 errors generated.
[2/33] Compiling OpenGraph_SPITests table_test_case.mm
error: fatalError In Package.swift let swiftToolchainPath = Context.environment["OPENGRAPH_SWIFT_TOOLCHAIN_PATH"] ?? (development ? "/Volumes/BuildMachine/swift-project" : "")
if !swiftToolchainPath.isEmpty {
sharedCSettings.append(
.unsafeFlags(
[
"-static",
"-DCOMPILED_WITH_SWIFT",
"-DPURE_BRIDGING_MODE",
"-UIBOutlet", "-UIBAction", "-UIBInspectable",
"-I\(swiftToolchainPath)/swift/include",
"-I\(swiftToolchainPath)/swift/stdlib/public/SwiftShims",
"-I\(swiftToolchainPath)/llvm-project/llvm/include",
"-I\(swiftToolchainPath)/llvm-project/clang/include",
"-I\(swiftToolchainPath)/build/Default/swift/include",
"-I\(swiftToolchainPath)/build/Default/llvm/include",
"-I\(swiftToolchainPath)/build/Default/llvm/tools/clang/include",
"-DLLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING", // Required to fix LLVM link issue
]
)
)
} After remove |
Got it and I'll fix it later. |
Thanks for the contribution. |
No description provided.