Skip to content

Add uncoveredBug test case for #73 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

Add uncoveredBug test case for #73 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 26 additions & 42 deletions Tests/OpenGraphCompatibilityTests/Attribute/Attribute/PointerOffsetTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,25 +104,7 @@ struct PointerOffsetTests {
#expect(pointer[offset: firstOffset] == 3)
#expect(pointer[offset: secondOffset].isApproximatelyEqual(to: 4.0))
}
#if !canImport(Darwin) && !DEBUG
// FIXME: The issue only occur on Linux + Release configuration (Swift 5.10)

// Uncomment the following withKnownIssue code will make the result back to normal thus causing 5 new issues
// withKnownIssue {
// withUnsafePointer(to: tuple) { pointer in
// #expect(pointer[offset: firstOffset] == 3)
// #expect(pointer[offset: secondOffset].isApproximatelyEqual(to: 4.0))
// }
// #expect(tuple.first == 3)
// #expect(tuple.second.isApproximatelyEqual(to: 4.0))
// }
withUnsafePointer(to: tuple) { pointer in
#expect(pointer[offset: firstOffset] == 1)
#expect(pointer[offset: secondOffset].isApproximatelyEqual(to: 2.0))
}
#expect(tuple.first == 1)
#expect(tuple.second.isApproximatelyEqual(to: 2.0))
#else
#if !(!canImport(Darwin) && !DEBUG)
withUnsafePointer(to: tuple) { pointer in
#expect(pointer[offset: firstOffset] == 3)
#expect(pointer[offset: secondOffset].isApproximatelyEqual(to: 4.0))
Expand Down Expand Up @@ -163,29 +145,7 @@ struct PointerOffsetTests {
#expect((pointer + secondOffset).pointee == 4)
#expect((pointer + thirdOffset).pointee == 5)
}
#if !canImport(Darwin) && !DEBUG
// FIXME: The issue only occur on Linux + Release configuration (Swift 5.10)

// Uncomment the following withKnownIssue code will make the result back to normal thus causing 7 new issues
// withKnownIssue {
// withUnsafePointer(to: triple) { pointer in
// #expect((pointer + firstOffset).pointee == 3)
// #expect((pointer + secondOffset).pointee == 4)
// #expect((pointer + thirdOffset).pointee == 5)
// }
// #expect(triple.first == 3)
// #expect(triple.second == 4)
// #expect(triple.third == 5)
// }
withUnsafePointer(to: triple) { pointer in
#expect((pointer + firstOffset).pointee == 0)
#expect((pointer + secondOffset).pointee == 1)
#expect((pointer + thirdOffset).pointee == 2)
}
#expect(triple.first == 0)
#expect(triple.second == 1)
#expect(triple.third == 2)
#else
#if !(!canImport(Darwin) && !DEBUG)
withUnsafePointer(to: triple) { pointer in
#expect((pointer + firstOffset).pointee == 3)
#expect((pointer + secondOffset).pointee == 4)
Expand All @@ -197,4 +157,28 @@ struct PointerOffsetTests {
#endif
}
}

#if !canImport(Darwin) && !DEBUG
@Test("Undefined Behavior Issue for PointerOffset", .bug("#73", relationship: .uncoveredBug))
func unsafePointerAndUnsafeMutablePointerExtensionUB() {
var tuple = Tuple(first: 1, second: 2)
typealias Base = Tuple<Int, Int>
let firstOffset = PointerOffset<Base, Int>(byteOffset: 0)
withUnsafeMutablePointer(to: &tuple) { pointer in
#expect(pointer[offset: firstOffset] == 1)
pointer[offset: firstOffset] = 3
}
let unexpectedValue = tuple.first
// The value will be unexpected due to UB
#expect(unexpectedValue == 1)
// The value will be expected after and within a withKnownIssue block
withKnownIssue {
let expectedValue = tuple.first
#expect(expectedValue == 3)
Issue.record("To make withKnownIssue pass")
}
let expectedValue = tuple.first
#expect(expectedValue == 3)
}
#endif
}