Skip to content

Windows named pipe path security check fix #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Windows named pipe path security check fix #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions openvpn/client/win/agentconfig.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,12 @@ class Agent
}

private:
// If path starts with C:\..., lower-case the drive letter.
// Convert to lower-case (in some cases GetModuleFileNameW returns lower case path).
// Then strip off the basename and only return the dir.
static std::string normalize_exe_path(const std::string &path)
{
std::string p;
if (path.length() >= 3
&& std::isalpha(static_cast<unsigned char>(path[0])) != 0
&& path[1] == ':'
&& path[2] == '\\')
p = string::to_lower_copy(path.substr(0, 3)) + path.substr(3);
else
p = path;
std::transform(p.begin(), p.end(), p.begin(), std::towlower);
p = path::dirname(p);
return p;
}
Expand Down