Skip to content

uk/Pattern ^[34][34]\d{2}$ is too restrictive for Ukrainian year formatting #19

@coderabbitai

Description

@coderabbitai

As per this comment in PR #1, @JarbasAl requested to open an issue to track the discussion.

ovos_date_parser/res/uk-ua/date_time.json

Pattern ^[34][34]\d{2}$ is too restrictive for Ukrainian year formatting

The test cases across multiple languages show that years between 3000-4000 follow consistent formatting patterns. The current regex ^[34][34]\d{2}$ only matches years like 3300-3499 and 4300-4499, but excludes valid cases like 3500-3999 that should follow the same format rule.

The pattern should be changed to ^[34]\\d{3}$ to cover all years in the 3000-4999 range
Line 14 can be removed since its pattern is now redundant with line 15

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions