-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
Description
As per the discussion in PR #1 and this comment, we need to expand the time format test coverage in ovos_date_parser/res/hu-hu/date_time_test.json
. The current test cases only cover a single time (13:22). The user @JarbasAl requested to open this issue to track this enhancement.
🛠️ Refactor suggestion
Expand time format test coverage
The current test cases only cover a single time (13:22). Consider adding test cases for:
- Midnight (00:00) and noon (12:00)
- Various morning hours (AM)
- Various evening hours (PM)
- Minute transitions (e.g., 8:59, 9:00)
Example additional test cases:
{
"3": {"datetime_param": "2017, 1, 31, 0, 0, 0", "now": "None", "use_24hour": "False", "use_ampm": "True", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, éjfél"},
"4": {"datetime_param": "2017, 1, 31, 12, 0, 0", "now": "None", "use_24hour": "False", "use_ampm": "True", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, dél"},
"5": {"datetime_param": "2017, 1, 31, 8, 59, 0", "now": "None", "use_24hour": "True", "use_ampm": "False", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, nyolc óra ötvenkilenc"}
}