-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: automations and tests #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JarbasAl
wants to merge
9
commits into
dev
Choose a base branch
from
tests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7365f7f
feat: automations and tests
JarbasAl 40f8e77
fix: format tests
JarbasAl 1f15b2f
fix: format tests
JarbasAl c3f11b8
fix: format tests
JarbasAl d702717
fix: format tests
JarbasAl 79732fe
fix: format tests
JarbasAl a68c9ba
semver
JarbasAl 7b472a2
semver
JarbasAl fe42c06
Apply suggestions from code review
JarbasAl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
name: Run Formatter UnitTests | ||
on: | ||
pull_request: | ||
branches: | ||
- dev | ||
paths-ignore: | ||
- 'ovos_date_parser/version.py' | ||
- 'requirements/**' | ||
- 'examples/**' | ||
- '.github/**' | ||
- '.gitignore' | ||
- 'LICENSE' | ||
- 'CHANGELOG.md' | ||
- 'MANIFEST.in' | ||
- 'README.md' | ||
- 'scripts/**' | ||
push: | ||
branches: | ||
- master | ||
paths-ignore: | ||
- 'ovos_date_parser/version.py' | ||
- 'requirements/**' | ||
- 'examples/**' | ||
- '.github/**' | ||
- '.gitignore' | ||
- 'LICENSE' | ||
- 'CHANGELOG.md' | ||
- 'MANIFEST.in' | ||
- 'README.md' | ||
- 'scripts/**' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
py_build_tests: | ||
uses: neongeckocom/.github/.github/workflows/python_build_tests.yml@master | ||
with: | ||
python_version: "3.8" | ||
|
||
unit_tests: | ||
strategy: | ||
matrix: | ||
python-version: [ 3.9, "3.10", "3.11" ] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install System Dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt install python3-dev | ||
python -m pip install build wheel | ||
- name: Install test dependencies | ||
run: | | ||
sudo apt install libssl-dev | ||
pip install pytest pytest-timeout pytest-cov | ||
- name: Install repo | ||
run: | | ||
pip install -e . ovos-config | ||
- name: Run parse unittests | ||
run: | | ||
pytest --cov=ovos_date_parser --cov-report xml test/format_tests | ||
- name: Upload coverage | ||
env: | ||
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}} | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
directory: ./coverage/reports/ | ||
fail_ci_if_error: true | ||
files: ./coverage.xml,!./cache | ||
flags: fmttests | ||
name: codecov-unittests | ||
verbose: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
name: Run Parser UnitTests | ||
on: | ||
pull_request: | ||
branches: | ||
- dev | ||
paths-ignore: | ||
- 'ovos_date_parser/version.py' | ||
- 'requirements/**' | ||
- 'examples/**' | ||
- '.github/**' | ||
- '.gitignore' | ||
- 'LICENSE' | ||
- 'CHANGELOG.md' | ||
- 'MANIFEST.in' | ||
- 'README.md' | ||
- 'scripts/**' | ||
push: | ||
branches: | ||
- master | ||
paths-ignore: | ||
- 'ovos_date_parser/version.py' | ||
- 'requirements/**' | ||
- 'examples/**' | ||
- '.github/**' | ||
- '.gitignore' | ||
- 'LICENSE' | ||
- 'CHANGELOG.md' | ||
- 'MANIFEST.in' | ||
- 'README.md' | ||
- 'scripts/**' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
py_build_tests: | ||
uses: neongeckocom/.github/.github/workflows/python_build_tests.yml@master | ||
with: | ||
python_version: "3.8" | ||
|
||
unit_tests: | ||
strategy: | ||
matrix: | ||
python-version: [ 3.9, "3.10", "3.11" ] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install System Dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt install python3-dev | ||
python -m pip install build wheel | ||
- name: Install test dependencies | ||
run: | | ||
sudo apt install libssl-dev | ||
pip install pytest pytest-timeout pytest-cov | ||
- name: Install repo | ||
run: | | ||
pip install ovos-config | ||
pip install -e . | ||
- name: Run parse unittests | ||
run: | | ||
pytest --cov=ovos_date_parser --cov-report xml test/parse_tests | ||
|
||
- name: Upload coverage | ||
env: | ||
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}} | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
directory: ./coverage/reports/ | ||
fail_ci_if_error: true | ||
files: ./coverage.xml,!./cache | ||
flags: parsetests | ||
name: codecov-unittests | ||
verbose: true |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,194 @@ | ||
# | ||
# Copyright 2017 Mycroft AI Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
import ast | ||
import datetime | ||
import json | ||
import unittest | ||
from pathlib import Path | ||
|
||
from ovos_config.locale import get_default_tz as default_timezone | ||
|
||
from ovos_date_parser import ( | ||
date_time_format, | ||
nice_date, | ||
nice_date_time, | ||
nice_year, | ||
nice_day, | ||
nice_month, | ||
nice_weekday, | ||
get_date_strings | ||
) | ||
|
||
|
||
class TestNiceDateFormat(unittest.TestCase): | ||
@classmethod | ||
def setUpClass(cls): | ||
# Read date_time_test.json files for test data | ||
cls.test_config = {} | ||
p = Path(date_time_format.config_path) | ||
for sub_dir in [x for x in p.iterdir() if x.is_dir()]: | ||
if (sub_dir / 'date_time_test.json').exists(): | ||
print("Getting test for " + | ||
str(sub_dir / 'date_time_test.json')) | ||
with (sub_dir / 'date_time_test.json').open() as f: | ||
cls.test_config[sub_dir.parts[-1]] = json.loads(f.read()) | ||
|
||
def test_nice_date(self): | ||
for lang in self.test_config: | ||
|
||
i = 1 | ||
while (self.test_config[lang].get('test_nice_date') and | ||
self.test_config[lang]['test_nice_date'].get(str(i))): | ||
p = self.test_config[lang]['test_nice_date'][str(i)] | ||
dp = ast.literal_eval(p['datetime_param']) | ||
np = ast.literal_eval(p['now']) | ||
dt = datetime.datetime( | ||
dp[0], dp[1], dp[2], dp[3], dp[4], dp[5]) | ||
now = None if not np else datetime.datetime( | ||
np[0], np[1], np[2], np[3], np[4], np[5]) | ||
print('Testing for ' + lang + ' that ' + str(dt) + | ||
' is date ' + p['assertEqual']) | ||
self.assertEqual(p['assertEqual'], | ||
nice_date(dt, lang=lang, now=now)) | ||
i = i + 1 | ||
|
||
# test all days in a year for all languages, | ||
# that some output is produced | ||
for lang in self.test_config: | ||
|
||
for dt in (datetime.datetime(2017, 12, 30, 0, 2, 3) + | ||
datetime.timedelta(n) for n in range(368)): | ||
self.assertTrue(len(nice_date(dt, lang=lang)) > 0) | ||
|
||
def test_nice_date_time(self): | ||
# TODO: migrate these tests (in res files) to respect the new | ||
# language loading features. Right now, some of them break if | ||
# their languages are not default. | ||
for lang in self.test_config: | ||
i = 1 | ||
while (self.test_config[lang].get('test_nice_date_time') and | ||
self.test_config[lang]['test_nice_date_time'].get(str(i))): | ||
p = self.test_config[lang]['test_nice_date_time'][str(i)] | ||
dp = ast.literal_eval(p['datetime_param']) | ||
np = ast.literal_eval(p['now']) | ||
dt = datetime.datetime( | ||
dp[0], dp[1], dp[2], dp[3], dp[4], dp[5], | ||
tzinfo=default_timezone()) | ||
now = None if not np else datetime.datetime( | ||
np[0], np[1], np[2], np[3], np[4], np[5], | ||
tzinfo=default_timezone()) | ||
print('Testing for ' + lang + ' that ' + str(dt) + | ||
' is date time ' + p['assertEqual']) | ||
self.assertEqual( | ||
p['assertEqual'], | ||
nice_date_time( | ||
dt, lang=lang, now=now, | ||
use_24hour=ast.literal_eval(p['use_24hour']), | ||
use_ampm=ast.literal_eval(p['use_ampm']))) | ||
i = i + 1 | ||
|
||
def test_nice_year(self): | ||
for lang in self.test_config: | ||
|
||
i = 1 | ||
while (self.test_config[lang].get('test_nice_year') and | ||
self.test_config[lang]['test_nice_year'].get(str(i))): | ||
p = self.test_config[lang]['test_nice_year'][str(i)] | ||
dp = ast.literal_eval(p['datetime_param']) | ||
dt = datetime.datetime( | ||
dp[0], dp[1], dp[2], dp[3], dp[4], dp[5]) | ||
print('Testing for ' + lang + ' that ' + str(dt) + | ||
' is year ' + p['assertEqual']) | ||
self.assertEqual(p['assertEqual'], nice_year( | ||
dt, lang=lang, bc=ast.literal_eval(p['bc']))) | ||
i = i + 1 | ||
|
||
# Test all years from 0 to 9999 for all languages, | ||
# that some output is produced | ||
for lang in self.test_config: | ||
|
||
print("Test all years in " + lang) | ||
for i in range(1, 9999): | ||
dt = datetime.datetime(i, 1, 31, 13, 2, 3, tzinfo=default_timezone()) | ||
self.assertTrue(len(nice_year(dt, lang=lang)) > 0) | ||
# Looking through the date sequence can be helpful | ||
|
||
|
||
class TestNiceDateUtils(unittest.TestCase): | ||
@classmethod | ||
def setUpClass(cls): | ||
cls.lang = 'en-us' | ||
|
||
def test_nice_day(self): | ||
# Test with include_month=True | ||
dt = datetime.datetime(2022, 10, 31) | ||
self.assertEqual(nice_day(dt, self.lang, 'MDY', True), "October 31") | ||
self.assertEqual(nice_day(dt, self.lang, 'DMY', True), "31 October") | ||
|
||
# Test with include_month=False | ||
self.assertEqual(nice_day(dt, include_month=False, lang=self.lang), "31") | ||
|
||
def test_nice_month(self): | ||
dt = datetime.datetime(2022, 10, 31) | ||
self.assertEqual(nice_month(dt, lang=self.lang), "October") | ||
|
||
def test_nice_weekday(self): | ||
dt = datetime.datetime(2022, 10, 31) | ||
self.assertEqual(nice_weekday(dt, lang=self.lang), "Monday") | ||
|
||
def test_get_date_strings(self): | ||
# Test with default arguments | ||
dt = datetime.datetime(2022, 10, 31, 13, 30, 0) | ||
expected_output = { | ||
"date_string": "10/31/2022", | ||
"time_string": "1:30", | ||
"month_string": "October", | ||
"day_string": "31", | ||
"year_string": "2022", | ||
"weekday_string": "Monday" | ||
} | ||
self.assertEqual(get_date_strings(dt, | ||
time_format="half", | ||
lang=self.lang), expected_output) | ||
|
||
# Test with different date_format | ||
expected_output = { | ||
"date_string": "31/10/2022", | ||
"time_string": "1:30", | ||
"month_string": "October", | ||
"day_string": "31", | ||
"year_string": "2022", | ||
"weekday_string": "Monday" | ||
} | ||
self.assertEqual(get_date_strings(dt, | ||
time_format="half", | ||
date_format='DMY', | ||
lang=self.lang), expected_output) | ||
|
||
# Test with different time_format | ||
expected_output = { | ||
"date_string": "10/31/2022", | ||
"time_string": "13:30", | ||
"month_string": "October", | ||
"day_string": "31", | ||
"year_string": "2022", | ||
"weekday_string": "Monday" | ||
} | ||
self.assertEqual(get_date_strings(dt, lang=self.lang), expected_output) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.