[Bug]: warning coming out of puppet lookup in 8.19.1

[robertc99]

Is this a critical security issue?

• This is not a security issue.

Describe the Bug

puppet lookup emits an meaningless warning

Expected Behavior

exactly the same without the warning.

Steps to Reproduce

root@rhc900-test2 rhc900]# puppet lookup nci::puppet::supported_version
Warning: The node parameter 'implementation' for node 'rhc900-test2.nci.org.au' was already set to 'openvox'. It could not be set to 'openvox'
--- 8.19.1

Environment

Version [e.g. 8.19.1]
Platform [rocky 9]

Additional Context

No response

Relevant log output

[bastelfreak]

@robertc99 thanks for the report, please run:

puppet lookup nci::puppet::supported_version --debug --trace

[binford2k]

The warning is emitted because both the client version and the server version of this fact have the same name. I forgot that the $server_facts has is also promoted to top-level flat facts. (in my opinion, that's a bug. The docs even tell you not to use them.)

https://www.puppet.com/docs/puppet/7/lang_facts_builtin_variables#lang_facts_builtin_variables-server-facts

[robertc99]

do you still want the puppet lookup output. Sounds like you have a handle on it.