Skip to content

Rebuild distribution files with last changes from 'src'; Fixes #122 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2017

Conversation

asgeir-s
Copy link

@asgeir-s asgeir-s commented Aug 28, 2017

Rebuild distribution files with last changes from 'src' and add npm build script.

One note; the build (gulp default) created a return statement:
return angularSchemaFormDynamicSelect;
on line 459 of angular-schema-form-dynamic-select.js. This had to be removed in order to get the new distribution working (I did not have the time to investigate this).

This fixes #122.

@asgeir-s asgeir-s mentioned this pull request Aug 28, 2017
@asgeir-s asgeir-s changed the title Rebuild distribution files with last changes from 'src' (fix #122) Rebuild distribution files with last changes from 'src'; Fixes #122 Aug 28, 2017
@nicklasb
Copy link
Member

nicklasb commented Aug 28, 2017

Hi, well, I usually rebuild source files when doing releases to keep the log clean, they are built anyway. Strange that they should not have been this release. Either way, yes, the line there has to be removed when using the non-uglyfied files.

@nicklasb nicklasb merged commit 56c6b9c into OptimalBPM:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled not working
2 participants