Skip to content

Add wOETH donation fork tests #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

shahthepro
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.76%. Comparing base (56d0b7d) to head (e54915e).
Report is 158 commits behind head on sparrowDom/woeth_hack_proof.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           sparrowDom/woeth_hack_proof    #2122    +/-   ##
=============================================================
  Coverage                        62.76%   62.76%            
=============================================================
  Files                               66       66            
  Lines                             3373     3373            
  Branches                           657      872   +215     
=============================================================
  Hits                              2117     2117            
  Misses                            1253     1253            
  Partials                             3        3            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahthepro shahthepro merged commit 52eb244 into sparrowDom/woeth_hack_proof Dec 17, 2024
15 of 16 checks passed
@shahthepro shahthepro deleted the shah/woeth-donations-tests branch December 17, 2024 12:50
sparrowDom added a commit that referenced this pull request Apr 15, 2025
* intermittent work committed

* add draft solution for preparing WOETH for the landing markets

* add tests that confirm lending market protection works as exepcted

* add test to protect agains calling initialize twice

* add comments

* remove unneeded files

* minor bug fix

* add fork script tests and fix bug

* add comments

* add another test

* divide after multiply

* change credits per token to highres

* add comment

* comments

* lint

* minor changes

* correct fixture

* make code slighlty better regarding re-entry

* prettier

* add explicit visibility

* minor test enhancement

* better function name

* remove comment

* simplify

* simplify code

* simplify code

* refactor

* add redeem all test

* prettier

* Add wOETH donation fork tests (#2122)

* Add wOETH donation fork tests

* test: add fork test for deposit/mint/withdraw/redeem.

* test: add test for redeem after rebase.

---------

Co-authored-by: clement-ux <[email protected]>

* rename deploy script

* add another test and simplify constructor

* fix: specify override for name and symbol.

* fix: import IERC20Metadata.

* add gap

* update reference to code

* fix compile errors

* move initialize2() into primary initializer

* remove virtual where not needed

* pick a more appropriate method for fetching highres CPT

* round in the favour of the protocol

* Revert "round in the favour of the protocol"

This reverts commit 637cd3c.

* rounding error fixes

* Option 1 for WOETH rounding error (#2419)

* option 1 to combat the rounding error

* naming

* simplify

* add comment

* prettier

* add require 0 checks

* allow 0 value mints and redeems

* to establish exchange rate for WOETH trust OETH completely

* remove unneeded overrides

* add comment and prettier

* fix a denomination bug

* add fork test for the expected rate increase

* add comment

* add tests for WOETH upgrade not changing the existing WOETH balances

* denominate all rates to 1e27 for better precision

* undo the change

* add comment

* further simplify the WOETH rate calculation code

* add comments

* prettier

* update test to confirm that redemption amounts of WOETH before and after the upgrade are a perfect (1 wei difference to rounding) match

* Fix bug with rounding direction on deposits

* nit: unify comment

* sligth code simplification

* fix typo

* remove unused imports

* remove todo

* switch to BUSL

* improve comment

* no need to call governable anymore

* fix comment

* make WOSonic extend WOETH. Add deploy file and basic fork test

* use the more appropriate natspec compliant inheritdoc

* more appropriate naming

* add aditiona test

* make WOUSD inherit from WOETH

* add deploy and fork test file for WOUSD

---------

Co-authored-by: Shah <[email protected]>
Co-authored-by: clement-ux <[email protected]>
Co-authored-by: Daniel Von Fange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants