Skip to content

[OS] Deploy Sonic 014 - upgrade Wrapped Sonic #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Conversation

sparrowDom
Copy link
Member

Description

  • Upgrade Wrapped Sonic

Code Changes

Deployment script

  • contracts/deploy/sonic/014_wrapped_sonic.js

Contracts

Contract Address
Wrapped Sonic 0x1CCB48fb244fE1f6eB0d1C5Fbd839DB78c6C5805

Contract differences

sol2uml diff 0x1CCB48fb244fE1f6eB0d1C5Fbd839DB78c6C5805 .,node_modules -n sonic

Governance

The following needs to be loaded into the Sonic 5/8 Admin multisig

contracts/deployments/sonic/operations/014_wrapped_sonic.schedule.json

After 24 hours, the following can be loaded into the 2/8 Guardian multisig

contracts/deployments/sonic/operations/014_wrapped_sonic.execute.json

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@naddison36
Copy link
Collaborator

naddison36 commented Apr 15, 2025

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

The mainnet unit tests are failing for WOETH.
The Sonic tests are also failing from the 014 deploy script.

sol2uml diff 0x1CCB48fb244fE1f6eB0d1C5Fbd839DB78c6C5805 .,node_modules -n sonic
Compared the "WOSonic" contract with address 0x1CCB48fb244fE1f6eB0d1C5Fbd839DB78c6C5805 on sonic
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/ERC20.sol
match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/Context.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/token/OETH.sol
match   contracts/token/OUSD.sol
match   contracts/token/WOETH.sol
match   contracts/token/WOSonic.sol
match   contracts/utils/Initializable.sol
match   lib/openzeppelin/contracts/token/ERC20/extensions/ERC4626.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.63%. Comparing base (f8ab900) to head (29c73f8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2483   +/-   ##
=======================================
  Coverage   40.63%   40.63%           
=======================================
  Files          96       96           
  Lines        4664     4664           
  Branches     1236     1236           
=======================================
  Hits         1895     1895           
  Misses       2767     2767           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@sparrowDom sparrowDom merged commit f41c43f into master Apr 17, 2025
16 of 19 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/deploy_14 branch April 17, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants