Add Safe module to help automate claim bribes #2510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2510 +/- ##
==========================================
- Coverage 40.89% 40.26% -0.64%
==========================================
Files 101 102 +1
Lines 4707 4801 +94
Branches 1242 1258 +16
==========================================
+ Hits 1925 1933 +8
- Misses 2780 2866 +86
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clement-ux
reviewed
May 9, 2025
Comment on lines
102
to
104
| uint256 _nftIndexEnd = nftIndexStart; | ||
| nftIndexStart = nftIndexEnd; | ||
| nftIndexEnd = _nftIndexEnd; |
There was a problem hiding this comment.
Maybe we can have something simple here:
(nftIndexStart, nftIndexEnd) = (nftIndexEnd, nftIndexStart)
There was a problem hiding this comment.
Ah, I didn't know this worked in Solidity, thanks
Comment on lines
316
to
320
| if (poolIndex >= _bribePools.length) { | ||
| return false; | ||
| } | ||
|
|
||
| return _bribePools[poolIndex].poolAddress == bribePool; |
There was a problem hiding this comment.
nit: Do you think it could be possible to have the same code structure as there is for nftIdExists()?
What I mean is that it could be nice to have all the value returned "calculated" on the return.
shahthepro
requested review from
sparrowDom,
DanielVF and
naddison36
as code owners
clement-ux
previously approved these changes
May 12, 2025
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- No interactions.
- Governance proposal matches the deploy script
- No governance
- Smoke tests pass after fork test execution of the governance proposal
Diff contract
sol2uml diff 0x5bd73897E92Ecf3E6295FFe5C1104E99000d2c98 .,node_modules -k VE23DGDT5V32ZIQI1RE4GS6NXZPW447GYX -n base
(node:4677) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "ClaimBribesSafeModule" contract with address 0x5bd73897E92Ecf3E6295FFe5C1104E99000d2c98 on base
to local files under folders ".,node_modules"
match @openzeppelin/contracts/access/AccessControl.sol
match @openzeppelin/contracts/access/AccessControlEnumerable.sol
match @openzeppelin/contracts/access/IAccessControl.sol
match @openzeppelin/contracts/access/IAccessControlEnumerable.sol
match @openzeppelin/contracts/utils/Context.sol
match @openzeppelin/contracts/utils/introspection/ERC165.sol
match @openzeppelin/contracts/utils/introspection/IERC165.sol
match @openzeppelin/contracts/utils/Strings.sol
match @openzeppelin/contracts/utils/structs/EnumerableSet.sol
match contracts/automation/ClaimBribesSafeModule.sol
match contracts/interfaces/aerodrome/ICLGauge.sol
match contracts/interfaces/aerodrome/ICLPool.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: