PHPCS 4.x | Initial updates to handle T_USE becoming a parentheses owner #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is owner `T_USE` tokens used for closure use statements are parentheses owners as of PHPCS 4.x. This makes a minor code adjustment to handle this in the `Operators::isReference()` method. The previous code would already handle it correctly, but this adds some forward-compatibility code for when support for PHPCS < 4 would be dropped. Refs: * squizlabs/PHP_CodeSniffer 2593 * squizlabs/PHP_CodeSniffer@08824f3 * squizlabs/PHP_CodeSniffer 3104 * squizlabs/PHP_CodeSniffer xxxx
…s opener `T_USE` tokens used for closure use statements are parentheses openers as of PHPCS 4.x. This includes the token having been added to the `Tokens::$parenthesisOpeners` array. This syncs that change into PHPCSUtils. The method itself does not need to change as it will automatically pick up on this. The unit test, however, does need updating. Refs: * squizlabs/PHP_CodeSniffer 2593 * squizlabs/PHP_CodeSniffer@08824f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS 4.x | Operators::isReference(): handle closure use as parenthesis owner
T_USEtokens used for closure use statements are parentheses owners as of PHPCS 4.x.This makes a minor code adjustment to handle this in the
Operators::isReference()method.The previous code would already handle it correctly, but this adds some forward-compatibility code for when support for PHPCS < 4 would be dropped.
A similar change will be pulled to PHPCS itself once squizlabs/PHP_CodeSniffer#3104, which fixes significant bugs in the current implementation of parenthesis support for
T_USEtokens, has been mergedPHPCS 4.x | BCTokens::parenthesisOpeners(): T_USE is now a parenthesis opener
T_USEtokens used for closure use statements are parentheses openers as of PHPCS 4.x.This includes the token having been added to the
Tokens::$parenthesisOpenersarray.This syncs that change into PHPCSUtils.
The method itself does not need to change as it will automatically pick up on this.
The unit test, however, does need updating.
Refs: