Fixer: remove output buffering #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now debug output is written to STDERR instead of STDOUT and the StatusWriter is paused while the Fixer is running, the output buffering during fixing can be removed. Co-authored-by: jrfnl <[email protected]>
jrfnl
force-pushed
the
phpcs-4.0/remove-output-buffering-from-fixer
branch
from
60b0f66 to
1df4347
Compare
|
Rebased without changes. Merging once the build has passed. |
|
For the record: this change was tested using the test setup as described in #1010. Also see the phpcs-4.0/pr-1010-explainer branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now debug output is written to STDERR instead of STDOUT and the StatusWriter is paused while the Fixer is running, the output buffering during fixing can be removed.
Suggested changelog entry
N/A (internal implementation detail)