When creationDate is false Mutator throws an exception

[Luciam91]

I'd expect this to fallback gracefully but when creationdate is set to false when reading the exif data the hydrate method of the Mutator throws a PHP Exception rather than returning all of the other data.

[Miljar]

The problem is not with the Hydrator. It's only job is to populate an object with given array of data. Not determine if it is allowed to populate it with a certain value. That's the job of the mapper.

The root cause of the problem is that probably the input format of the creation date does not match the expected Y:m:d H:i:s format. It will return a false value, which is then via the Hydrator passed on the the setCreationDate method on the Exif object. This however has a typehint of \DateTime, which causes the exception.

The real solution here would be to catch this false value in the appropriate Mapper object, and skip mapping when false is returned when trying to create a \DateTime object from the input value.

Can you update your pull request like this:

• Remove your solution
• Create a unit test to demonstrate the problem
• Create a fix in the Mapper classes for creation date only

If you are unable to do this, just let me know. Then I'll do it, but this seems like a perfect "easy pick" to allow you to contribute to the project ;-)

[Luciam91]

Working on this now; however is only creating the DateTime object from values which map to a specific string format not a little inhibiting? Should it not attempt to create a DateTime object no matter the format?