createDrawingShape stopped working in 1.1.0

[sinnbeck]

I am adding images to a powerpoint and it was working fine in v1.0.

This is the code

foreach ($images as $imagePath) {
    $slide = $presentation->createSlide();
    $shape = $slide->createDrawingShape();
    $shape->setPath($imagePath);
    $shape->setResizeProportional(true);
    $shape->setWidth($width);
    $shape->setOffsetX(0);
    $shape->setOffsetY(0);
    $shape->setName('Content');
    $shape->setDescription('Content');
}

Now after updating I just get an empty page with "Content"

It works if I use this, but I want to add them as drawing shapes

$image = new Image();
$image->setPath($imagePath);
$slide->setBackground($image);

[omarjavierr277]

I am adding images to a powerpoint and it was working fine in v1.0.

code

$imageFile = new File();
$imageFile->setPath($filePath)->setName(time());
$this->activeSlide->addShape($imageFile);

[eandradesoft]

I'm having the same issue… has anyone found a solution?

[andy96453]

Same problem, I am creating a powerpoint file with an image on each slide all was working corectly, when upgraded to 1.1 only a few slides had images the rest were broken when writing out to PowerPoint2007

[kw-pr]

Quick fix: Change name or description for each image ->setDescription('lorum ipsum' . random_int(0, 99999))

What I got so far
The following are my notes during the search:

Same here. Drawing works the first time but if used again the image does not show.

I checked src/PhpPresentation/Shape/Drawing/File.php but is does not have any big changes. Problem is somewhere else...

Unpacking the .pptx files: the slides and rels files look fine.
But the images are missing in ppt/media/.

In PptMedia the images are missing from getDrawingHashTable().

They disappear in src/PhpPresentation/Writer/PowerPoint2007.php Line 98:

$this->getDrawingHashTable()->addFromSource($this->allDrawings());

Looks like getHashCode() is the same for my images.
There is AbstractGraphic::getHashCode() and AbstractShape::getHashCode() involved. Second one was changed, but I don't see any problem. Same problem with the old AbstractShape::getHashCode() function.

AbstractGraphic looks like this:

public function getHashCode(): string
{
    return md5($this->name . $this->description . parent::getHashCode() . __CLASS__);
}

If you change name or description of the image the hash changes all images show up.

Only a hack. Not a real solution, yet.

In v1.0.0 $this->container->getHashCode() is always different!

In v1.1.0 container is empty in AbstractShape.

addShape function was removed in many places:

src/PhpPresentation/Slide/AbstractSlide.php
src/PhpPresentation/Slide/Animation.php
src/PhpPresentation/Slide/Note.php
src/PhpPresentation/Shape/Group.php

But it is still in the interface and I think it is used. Should throw an exception?

Ah, addShape that is in PhpOffice\PhpPresentation\Traits\ShapeCollection now. But there is no $shape->setContainer($this); anymore.

[Progi1984]

This issue has been fixed by a maintainer. You can help him by sponsoring him through Github sponsors.