Skip to content

Remove % signs from PptCharts to fix chart generation. Fixes #452 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

bkanber
Copy link
Contributor

@bkanber bkanber commented Feb 8, 2018

I have removed two instances of % signs in PptCharts which cause presentations with charts to be corrupted on newer versions of Powerpoint. I have also updated the test suite to match.

However I am unsure if the changes I've made to the test schema are acceptable. Please let me know and I can updated.

Fixes issue #452 and possibly a couple others.

@bkanber
Copy link
Contributor Author

bkanber commented Feb 8, 2018

Regarding the changes I made to the test schema: I looked up the schema here http://www.datypic.com/sc/ooxml/s-dml-chart.xsd.html and added the xsd:unsignedShort to the union statement, as both of the types in question are listed as being derived from xsd:unsignedShort. I have left in the percent sign types in the union, figuring that this would allow for some backwards compatibility in validation, however let me know if you would like me to update that schema. I'm just not really sure what it's properly supposed to be.

@Progi1984 Progi1984 merged commit ba7ca1a into PHPOffice:develop Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants