[Feature]add model status #4302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LiqinruiG
reviewed
Sep 30, 2025
| request.set("temperature", 1) | ||
| if request.get("top_p") < _SAMPLING_EPS: | ||
| request.set("top_p", _SAMPLING_EPS) | ||
| if self.reasoning_parser and self.reasoning_parser.__class__.__name__ == "ErnieX1ReasoningParser": |
| if request.get("top_p") < _SAMPLING_EPS: | ||
| request["top_p"] = _SAMPLING_EPS | ||
| if self.reasoning_parser and self.reasoning_parser.__class__.__name__ == "ErnieX1ReasoningParser": | ||
| request["enable_thinking"] = True |
| if response_dict.outputs.text == "" and response_dict.outputs.reasoning_content == "": | ||
| return None | ||
| if req_id in self.model_status_dict: | ||
| del self.model_status_dict[req_id] |
There was a problem hiding this comment.
要在上面的 return之前 做del 的判断。
| request.enable_thinking = True | ||
| if self.reasoning_parser: | ||
| model_status = self.reasoning_parser.get_model_status(request.prompt_token_ids) | ||
| self.model_status_dict[request.request_id] = model_status |
There was a problem hiding this comment.
在 n 参数的场景， request_id = XX_m， 在后处理的 response 中取到的 req_id， 是 XX_m_n， 会造成取不到这个 model_status
| enable_thinking=enable_thinking, | ||
| **kwargs, | ||
| ) | ||
|
|
There was a problem hiding this comment.
还有一个 qwen_vl 的processor， 看看是不是需要修改。
| reasoning_content = delta_text[:end_index] | ||
| content = delta_text[end_index + len(self.think_end_token) :] | ||
| return DeltaMessage(reasoning_content=reasoning_content, content=content) | ||
| elif self.think_end_token_id in previous_token_ids: |
There was a problem hiding this comment.
直接用 if 就可以，不用 elif。 下面也不需要 else
| self.think_end_token_id, | ||
| self.response_start_token_id, | ||
| self.response_end_token_id, | ||
| ]: |
There was a problem hiding this comment.
如果遇到的是 tool_call 的special, 也可以直接返回 none 了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Add the
get_model_statusmethod in thereasoning_parserto obtain the model's status, and determine how to perform parsing based on the status.2.Remove the judgment of
enable_thinking.