Change the exception of getitem from pybind type to PADDLE_ENFORCE #40530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Mar 14, 2022
| std::to_string(-dim_len) + ", " + std::to_string(dim_len) + ")"; | ||
| // py::index_error is corresponding to IndexError in Python | ||
| // Used to indicate out of bounds access in __getitem__, __setitem__ | ||
| throw py::index_error(str_error_message); |
There was a problem hiding this comment.
框架还有几个 throw py::index_error() 建议也一起改下
There was a problem hiding this comment.
剩余的py::index_error()在另一个PR40538中移除
zhwesky2010
previously approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Change the exception throwing type of getitem from pybind type to PADDLE_ENFORCE.