Skip to content

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Mar 14, 2022

PR types

New features

PR changes

Others

Describe

This PR adds additional parameters to save_quant_model.py to define the names of the input and output files. The default version of the input and output file names remains the same as before.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wozna wozna added the Intel label Mar 14, 2022
@wozna wozna added the int8 label Mar 14, 2022
test_args.ops_to_quantize, test_args.op_ids_to_skip, test_args.debug)
test_args.ops_to_quantize, test_args.op_ids_to_skip, test_args.debug,
test_args.save_model_filename, test_args.save_params_filename,
test_args.quant_model_filename, test_args.quant_params_filename)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quant_xxx_filename should be first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right. Thank you

Copy link

@sfraczek sfraczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wozna wozna requested a review from lidanqing-vv March 15, 2022 11:05
@wozna wozna assigned lidanqing-vv and sfraczek and unassigned sfraczek Mar 15, 2022
Copy link
Contributor

@lidanqing-vv lidanqing-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv lidanqing-vv merged commit dec2b1c into PaddlePaddle:develop Mar 16, 2022
liqitong-a pushed a commit to liqitong-a/Paddle that referenced this pull request Mar 17, 2022
…es (PaddlePaddle#40542)

* Modify save_quant_model.py to support differnet input and output filenames

* Correct wrong order of arguments
@wozna wozna deleted the correct_save_quant_model branch February 24, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants