Skip to content

Conversation

PaperStrike
Copy link
Owner

@PaperStrike PaperStrike commented Nov 2, 2021

Motivation and Context

  • Ignore session history entries that are not pushed / replaced by Pjax.
  • Change window scroll restoration mode only when needed.
  • Use the scrollRestoration option when leaving, not entering a page.

How Has This Been Tested?

Unfortunately, there isn't a test plan for src/index.ts, yet.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

* Ignore session history entries that are not pushed by Pjax.
* Change window scroll restoration mode only when needed.
* Use the `scrollRestoration` option when leaving, not entering a page.
@PaperStrike PaperStrike added enhancement New feature or request minor Pull requests that require a minor version update labels Nov 2, 2021
@PaperStrike PaperStrike marked this pull request as draft November 2, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Pull requests that require a minor version update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant