build without debug symbols and exclude source from wheels #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enkore
commented
Jan 18, 2022
gpg: assuming signed data in 'libssh-0.9.6.tar.xz' gpg: Signature made Do 26 Aug 2021 14:28:25 CEST gpg: using RSA key 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D gpg: Good signature from "Andreas Schneider <[email protected]>" [unknown] gpg: aka "Andreas Schneider <[email protected]>" [unknown] gpg: aka "Andreas Schneider <[email protected]>" [unknown] Primary key fingerprint: 8DFF 53E1 8F2A BC8D 8F3C 9223 7EE0 FC4D CC01 4E3D
|
rebased for CI fix |
pkittenis
requested changes
Feb 3, 2022
| @@ -47,7 +47,7 @@ | |||
| ] | |||
|
|
|||
| # _comp_args = ["-ggdb"] | |||
| _comp_args = ["-O3"] if not ON_WINDOWS else None | |||
| _comp_args = ['-O3', '-g0', '-s'] if not ON_WINDOWS else None | |||
There was a problem hiding this comment.
It behaves similar to stripping afterwards but it's not exactly the same (stripping still reduces size a little bit). -g0 undoes the -g added by setuptools by default.
There was a problem hiding this comment.
Cool. Might be worth checking if -Os instead of -O3 reduces size any further. Doubt the O3 optimisations are making much of a difference in speed.
pkittenis
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on top of #41 due to touching the same files
Fixes #43
(eref 42d478fb6976)