Add multiple features, bug fixes and update libssh2 to the latest stable. #94
Conversation
This enables giving ssh a prefered list of options such as kex, ciphers, MACs and etc
Add libsssh2_session_method_pref
Add recompiled cython files
Regenerate Cython files. Add `ssh2.session.Session.method_pref()` doc string. Update .gitignore to include src directory to ignore libssh2 rebuilds.
Add additional error codes. Add `session.method_pref()` docs and tests. Add `session.methods()`, docs and tests. Add `session.supported_algs()`, docs and tests. Add `session.flag()`, docs and tests. Bug fix for `session.userauth_publickey_frommemory()` being provided no public key and throwing a type error.
Add callback function typedef for keyboard interactive authentication. Add `ctypedef`s for keyboard interactive authentication. Fix keyboard interactive authentication function def in c_ssh. Internally hide that `libssh2_userauth_keyboard_interactive` takes a callback function and not a string...
Add enums to clean up any symbols from libssh2 and make interacting with them much easier to do. Add additional unit tests for ParallelSSH#86
Correct issue in `ssh2.sftp_handel.SFTPHandle.readdir*()` which adds EAGAIN items into the generators.
Rename library to redlibssh2.
Red-M
changed the title
|
Thanks for splitting off dedicated PR branch. Could you revert the changes that rename |
This comment was marked as spam.
This comment was marked as spam.
|
seems like appveyor isn't happy May I suggest trying to move to travis ? (they now support windows and mac) |
This comment was marked as spam.
This comment was marked as spam.
FYI you can build on travis for multiple platfrom quite easily with cibuildwheel It's breaks my heart to see those kind of failures.... |
|
Thanks for the PR. Have made similar changes, will aim to get these in. If @Red-M is interested can add you to this project. As has been obvious from this PR, there is only so much one maintainer can do. |
|
| Thanks for splitting off dedicated PR branch. Could you revert the changes that rename ssh2 to redlibssh2 in this branch? I assume the maintainer(s) will require that before it can be merged. Yes. |
|
| I'll be happy to give a hand with such a setup if you want [cibuildwheel] @fruch , if you would like to take a stab at re-doing the wheel builds for travis CI would welcome a PR. |
| @@ -0,0 +1,3 @@ | |||
| [submodule "libssh2"] | |||
There was a problem hiding this comment.
Would rather not use submodules. It adds quite a bit of overhead on the developer and can be confusing to work with. The source code is included in the repo so as not to have to use submodules.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
|
Closing this so can split the various tasks into different PRs. Libssh2 upgrade is being done in #101 In general better to do one thing per PR to make reviewing easier, eg API implementation, libssh2 upgrade, bug fixes etc. This PR has too many unrelated changes to effectively review at once. |
This comment was marked as spam.
This comment was marked as spam.
This is a new PR (from #90) to track the branch of changes for upstream as I see it now that I am required to make my own changes and publish under a new name as it appears the maintainer has disappeared.
The changes are as follows. I also recommend reading the commit messages and the changes on each commit instead of the roll up diff as it is HUGE.
Changes