DRAFT: Elastic prep text incorporation #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create new sql-templated operators in dag * add upstream/downstream links to new operators * simplify operator dependency assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized I neglected to add the actual dag tasks when i added the new sql template files in PR#189 🤦
This adds the new operators, places them in the dependency flow, and makes a couple tweaks to the upstream/downstream dependency assignment to separate the tasks that the granted and pre-grant QC tasks respectively depend on.
Assigning to @gchickering21 for QC to make sure I haven't mucked up any dependencies that you intended.
@blue-webb and @heavenklair for awareness.
no need to re-run this dag for this update after this PR - I'll make the missing views manually.
I also still need to make a commit for adding the new text tables to the files resources/table_config_elasticsearch_patent.json and resources/table_config_elasticsearch_pgpub.json, so this is a draft for the moment, but wanted to put it on your radar.