Re-enable console window and properly shutdown on subscript crash #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
force-pushed
the
utf_learnings
branch
from
1fe29a6 to
a3e5463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroring out in subscripts caused the process to hang out in the background because we removed the console window that would show the error and be the UI handle for the process. This was confusing for users and made it hard to debug.
Re-enabling this window might not be the cleanest solution, but seems to work fine in the base case.
To test the crash message, return an object instead of string values from a subscript and trigger that subscript. E.g. in Launch.lua, add curly braces around the DownloadPage response like so:
Then go to Items -> Trade for these items to trigger a page download.