fix: #891, #883, #882, #881, and issue when building component libraries for react-leaflet (#897) #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miccoh1994
changed the title
miccoh1994
changed the title
miccoh1994
changed the title
|
Using the single fix in #885 |
eapearson
added a commit
to kbaseincubator/react-leaflet
that referenced
this pull request
Jul 9, 2021
|
Thanks but the core package is a direct dependency, not a peer one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issues:
Also fixes an issue when using/developing components from external packages by requiring '@react-leaflet/core' as a peer dependecy:
No context provided: useLeafletContext() can only be used in a descendant of <MapContainer>Since @react-leaflet/core, and consequently
useLeafletContext, are bundled with react-leaflet, components created with core do not have access to the same context as the MapContainer. This is only achievable by excluding @react-leafler/core from the bundle of react-leaflet.