-
Notifications
You must be signed in to change notification settings - Fork 577
Leak & Fail to compile Perl with ithreads and clang #18108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think a lot of these might be due to Perl_destruct bailing out early if it's the parent thread (or non-threaded build). If we define a couple of macros to implement this:
They could then be used to skip early bail-out when ASan is in use. |
Also been meaning to check if there's a regular ASan smoker or not. |
please use C89 comment style only.
|
@Tux - code above was just a rushed copy&paste from https://clang.llvm.org/docs/AddressSanitizer.html#conditional-compilation-with-has-feature-address-sanitizer, didn't mean to imply that's code to go directly into a PR. Looks like we don't already have a |
Yes, sounds ok |
@atoomic - if you comment out https://github.com/Perl/perl5/blob/blead/perl.c#L948, are there any leaks left? |
@richardleach I'm not sure to understand the change you are suggesting, could you show me a diff? |
|
@richardleach commenting that |
Ok. I'm happy to have a crack at implementing the macros mentioned above and using them to prevent that early |
excellent thanks |
On Wed, Sep 02, 2020 at 10:45:23AM -0700, Richard Leach wrote:
Ok. I'm happy to have a crack at implementing the macros mentioned above
and using them to prevent that early `return STATUS_EXIT;` when built
with ASan.
I don't like that idea.
I run ASan leak detect runs with the env var PERL_DESTRUCT_LEVEL=2.
It passes for me.
…--
Any [programming] language that doesn't occasionally surprise the
novice will pay for it by continually surprising the expert.
-- Larry Wall
|
That is documented in perlhacktips.pod, which I clearly hadn't read thoroughly enough. :( Agree that there's therefore nothing to do. |
Notice this error with the following tags:
Configure output used
Extract from
make
also view: #18012 and #18054
probably linked to #18107
The text was updated successfully, but these errors were encountered: