Skip to content

SAVESTRLEN() is missing #19165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leonerd opened this issue Oct 3, 2021 · 0 comments · Fixed by #19166
Closed

SAVESTRLEN() is missing #19165

leonerd opened this issue Oct 3, 2021 · 0 comments · Fixed by #19166

Comments

@leonerd
Copy link
Contributor

leonerd commented Oct 3, 2021

Many of the savestack types have associated public macros, e.g. SAVEINT, SAVEVPTR, etc...

SAVESTRLEN appears to be lacking.

Core internal code currently makes use of a (lowercased) save_strlen() macro that isn't made public.

I suggest renaming it to capitals without the _, SAVESTRLEN, and making it public.

(I'll probably send a PR to do this tomorrow)
@leonerd leonerd mentioned this issue Oct 3, 2021
Merged
leonerd added a commit to leonerd/perl5 that referenced this issue Oct 5, 2021
@leonerd
Expose a public SAVESTRLEN() macro
b64547f 
This seems to have been forgotten in the public API, perhaps because it
was added later.

Fixes Perl#19165
leonerd added a commit that referenced this issue Oct 5, 2021
@leonerd
Expose a public SAVESTRLEN() macro
58541fd 
This seems to have been forgotten in the public API, perhaps because it
was added later.

Fixes #19165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide SAVESTRLEN() macro leonerd/perl5
1 participant
@leonerd