Failed test 'mtime preserved by copy() while testing cross-partition' #20018

g055s00 · 2022-07-30T17:55:48Z

Tried different MSVC and Perl versions.

ok 52 - contents preserved
not ok 53 - mtime preserved by copy() while testing cross-partition

#   Failed test 'mtime preserved by copy() while testing cross-partition'
#   at ../lib/File/Copy.t line 126.
#          got: '1000007200'
#     expected: '1000003600'

Test Summary Report
-------------------
../lib/File/Copy.t (Wstat: 256 (exited 1) Tests: 466 Failed: 1)
  Failed test:  53
  Non-zero exit status: 1
Files=1, Tests=466,  0 wallclock secs ( 0.00 usr +  0.06 sys =  0.06 CPU)
Result: FAIL
NMAKE : fatal error U1077: '.\perl.exe' : return code '0x1'
Stop.

Steps to Reproduce
Build using win32/Makefile in accordance with the README.win32

Perl configuration

Summary of my perl5 (revision 5 version 36 subversion 0) configuration:
  
  Platform:
    osname=MSWin32
    osvers=10.0.19044.1865
    archname=MSWin32-x64-multi-thread
    uname=''
    config_args='undef'
    hint=recommended
    useposix=true
    d_sigaction=undef
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=undef
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cl'
    ccflags ='-nologo -GF -W3 -MD -DWIN32 -D_CONSOLE -DNO_STRICT -DWIN64 -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS  -DPERL_TEXTMODE_SCRIPTS -DMULTIPLICITY -DPERL_IMPLICIT_SYS'
    optimize='-O1 -Zi -GL -fp:precise'
    cppflags='-DWIN32'
    ccversion='19.32.31332'
    gccversion=''
    gccosandvers=''
    intsize=4
    longsize=4
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=undef
    longlongsize=8
    d_longdbl=define
    longdblsize=8
    longdblkind=0
    ivtype='__int64'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='__int64'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='link'
    ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf -ltcg  -libpath:"c:\perl\lib\CORE"  -machine:AMD64 -subsystem:console,"5.02"'
    libpth="C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\\lib\x64"
    libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib vcruntime.lib ucrt.lib
    perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib vcruntime.lib ucrt.lib
    libc=ucrt.lib
    so=dll
    useshrplib=true
    libperl=perl536.lib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs
    dlext=dll
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf -ltcg  -libpath:"c:\perl\lib\CORE"  -machine:AMD64 -subsystem:console,"5.02"'


Characteristics of this binary (from libperl):
  Compile-time options:
    HAS_TIMES
    HAVE_INTERP_INTERN
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_IMPLICIT_SYS
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
    USE_THREAD_SAFE_LOCALE
  Built under MSWin32

The text was updated successfully, but these errors were encountered:

jkeenan · 2022-07-30T19:22:51Z

@mikhail-rakhmanov, for my own analysis I stripped down lib/File/Copy.t to the following program, which ran without incident on both Linux and FreeBSD.

$ cat gh-20018-mtime.pl 
use strict;
use warnings;
use File::Copy qw(move);
use Test::More;
{
  # Simulate a cross-partition copy/move by forcing rename to
  # fail.
  no warnings 'redefine';
  no warnings 'once';
  *CORE::GLOBAL::rename = sub { 0 };
}
# First we create a file
open(F, ">", "before-$$") or die $!;
binmode F; # for DOSISH platforms, because test 3 copies to stdout
printf F "ok\n";
close F;

note "before atime: " . (stat("before-$$"))[8];
note "before mtime: " . (stat("before-$$"))[9];

# Doesn't really matter what time it is as long as its not now.
my $time = 1000000000.12345;
utime( $time, $time, "before-$$" );
note "utime applied";
note "before atime: " . (stat("before-$$"))[8];
note "before mtime: " . (stat("before-$$"))[9];

# Recheck the mtime rather than rely on utime in case we're on a
# system where utime doesn't work or there's no mtime at all.
# The destination file will reflect the same difficulties.
my $mtime = (stat("before-$$"))[9];

ok move("before-$$", "after-$$"), 'move';
ok -e "after-$$",   'destination exists';
ok !-e "before-$$", 'source does not';

my $dest_mtime = (stat("after-$$"))[9];
is $dest_mtime, $mtime,
  "mtime $mtime preserved by copy() while testing cross-partition";

unlink "after-$$";
done_testing();

Could you try it on your Windows system(s) and tell us if you got the same failures?

We'll need to have this examined by people with more Windows experience than me.

@xenu, @sisyphus, @tonycoz, @craigberry

g055s00 · 2022-07-30T19:30:39Z

@mikhail-rakhmanov, for my own analysis I stripped down lib/File/Copy.t to the following program, which ran without incident on both Linux and FreeBSD.

$ cat gh-20018-mtime.pl 
use strict;
use warnings;
use File::Copy qw(move);
use Test::More;
{
  # Simulate a cross-partition copy/move by forcing rename to
  # fail.
  no warnings 'redefine';
  no warnings 'once';
  *CORE::GLOBAL::rename = sub { 0 };
}
# First we create a file
open(F, ">", "before-$$") or die $!;
binmode F; # for DOSISH platforms, because test 3 copies to stdout
printf F "ok\n";
close F;

note "before atime: " . (stat("before-$$"))[8];
note "before mtime: " . (stat("before-$$"))[9];

# Doesn't really matter what time it is as long as its not now.
my $time = 1000000000.12345;
utime( $time, $time, "before-$$" );
note "utime applied";
note "before atime: " . (stat("before-$$"))[8];
note "before mtime: " . (stat("before-$$"))[9];

# Recheck the mtime rather than rely on utime in case we're on a
# system where utime doesn't work or there's no mtime at all.
# The destination file will reflect the same difficulties.
my $mtime = (stat("before-$$"))[9];

ok move("before-$$", "after-$$"), 'move';
ok -e "after-$$",   'destination exists';
ok !-e "before-$$", 'source does not';

my $dest_mtime = (stat("after-$$"))[9];
is $dest_mtime, $mtime,
  "mtime $mtime preserved by copy() while testing cross-partition";

unlink "after-$$";
done_testing();

Could you try it on your Windows system(s) and tell us if you got the same failures?

We'll need to have this examined by people with more Windows experience than me.

@xenu, @sisyphus, @tonycoz, @craigberry

# before atime: 1659209248
# before mtime: 1659209248
# utime applied
# before atime: 1000003600
# before mtime: 1000003600
ok 1 - move
ok 2 - destination exists
ok 3 - source does not
ok 4 - mtime 1000003600 preserved by copy() while testing cross-partition
1..4

jkeenan · 2022-07-30T19:48:11Z

$ cat gh-20018-mtime.pl

...

my $time = 1000000000.12345;
utime( $time, $time, "before-$$" );
note "utime applied";
note "before atime: " . (stat("before-$$"))[8];
note "before mtime: " . (stat("before-$$"))[9];
# before atime: 1659209248
# before mtime: 1659209248
# utime applied
# before atime: 1000003600
# before mtime: 1000003600
ok 1 - move
ok 2 - destination exists
ok 3 - source does not
ok 4 - mtime 1000003600 preserved by copy() while testing cross-partition
1..4

Do you have any insight into why, on your system, applying utime() to modify the access and modification times of the test file caused those times to be recorded as 3600 seconds -- one hour -- greater than the time arbitrarily provided?

Leont · 2022-07-30T20:03:49Z

Do you have any insight into why, on your system, applying utime() to modify the access and modification times of the test file caused those times to be recorded as 3600 seconds -- one hour -- greater than the time arbitrarily provided?

@mikhail-rakhmanov what timezone are you in?

g055s00 · 2022-07-30T20:16:55Z

Do you have any insight into why, on your system, applying utime() to modify the access and modification times of the test file caused those times to be recorded as 3600 seconds -- one hour -- greater than the time arbitrarily provided?

@mikhail-rakhmanov what timezone are you in?

UTC+03 Moscow was the issue
I changed it, and now test successful.

jkeenan · 2022-07-30T20:18:41Z

Do you have any insight into why, on your system, applying utime() to modify the access and modification times of the test file caused those times to be recorded as 3600 seconds -- one hour -- greater than the time arbitrarily provided?

@mikhail-rakhmanov what timezone are you in?

UTC+03 Moscow was the issue I changed it, and now test successful.

Thanks for your quick responses. Since the test now passes, I am closing this ticket.

xenu · 2022-08-07T22:03:38Z

Perl should work in all time zones. Reopening.

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes Perl#20018, Perl#20061

xenu · 2022-08-07T23:01:12Z

This seems to have the same underlying cause as #20061, so #20064 should fix it.

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes #20018, #20061

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes Perl#20018, Perl#20061

g055s00 added the Needs Triage label Jul 30, 2022

jkeenan added distro-mswin32 and removed Needs Triage labels Jul 30, 2022

jkeenan closed this as completed Jul 30, 2022

xenu reopened this Aug 7, 2022

xenu added a commit to xenu/perl5 that referenced this issue Aug 7, 2022

win32.c: use _mkgmtime() instead of mktime() in stat()

13c51f8

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes Perl#20018, Perl#20061

xenu mentioned this issue Aug 7, 2022

win32.c: use _mkgmtime() instead of mktime() in stat() #20064

Merged

xenu closed this as completed in #20064 Aug 9, 2022

xenu added a commit that referenced this issue Aug 9, 2022

win32.c: use _mkgmtime() instead of mktime() in stat()

f7e7b4d

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes #20018, #20061

scottchiefbaker pushed a commit to scottchiefbaker/perl5 that referenced this issue Nov 3, 2022

win32.c: use _mkgmtime() instead of mktime() in stat()

4239459

Conversion to local time seems unnecessary and it apparently causes issues with DST. Fixes Perl#20018, Perl#20061

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Failed test 'mtime preserved by copy() while testing cross-partition' #20018

Failed test 'mtime preserved by copy() while testing cross-partition' #20018

g055s00 commented Jul 30, 2022

jkeenan commented Jul 30, 2022

Uh oh!

g055s00 commented Jul 30, 2022

Uh oh!

jkeenan commented Jul 30, 2022

Uh oh!

Leont commented Jul 30, 2022

Uh oh!

g055s00 commented Jul 30, 2022

Uh oh!

jkeenan commented Jul 30, 2022

Uh oh!

xenu commented Aug 7, 2022 •

edited

Loading

Uh oh!

xenu commented Aug 7, 2022

Uh oh!

Failed test 'mtime preserved by copy() while testing cross-partition' #20018

Failed test 'mtime preserved by copy() while testing cross-partition' #20018

Comments

g055s00 commented Jul 30, 2022

jkeenan commented Jul 30, 2022

Uh oh!

g055s00 commented Jul 30, 2022

Uh oh!

jkeenan commented Jul 30, 2022

Uh oh!

Leont commented Jul 30, 2022

Uh oh!

g055s00 commented Jul 30, 2022

Uh oh!

jkeenan commented Jul 30, 2022

Uh oh!

xenu commented Aug 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xenu commented Aug 7, 2022

Uh oh!

xenu commented Aug 7, 2022 •

edited

Loading