9fdd7fc479 breaks build using g++ as compiler #20108

jkeenan · 2022-08-17T14:35:35Z

A recent commit to blead has broken the build when using g++ as the C-compiler.

I first noticed this breakage in recent smoke-test reports such as this one.

Bisecting with this invocation:

perl Porting/bisect.pl \
-Dcc=g++ \
--test-build \
--start cf1717027b95225cb27f33b15b84ff798c8bacaf \
--end 40666a761f261de4ec02a7fd4e770a48957df7c7

... points to this commit:

9fdd7fc4796d89d16dceea42f2af91e4fde296ed is the first bad commit
commit 9fdd7fc4796d89d16dceea42f2af91e4fde296ed
Author: Richard Leach <[email protected]>
Date:   Fri Jul 8 14:52:19 2022 +0000
Commit:     Richard Leach <[email protected]>
CommitDate: Wed Aug 17 11:19:10 2022 +0100

 
    Implement OP_PADSV_STORE - combined sassign/padsv OP

    This commit introduces a new OP to replace simple cases
    of OP_SASSIGN and OP_PADSV.

@richardleach, can you take a look?

@neilb, can you keep an eye on this, as it will affect the monthly dev release scheduled for Saturday Aug 20? Thanks.

The text was updated successfully, but these errors were encountered:

jkeenan · 2022-08-17T14:38:34Z

Compilation on FreeBSD-12 using g++ version 10.3.0 ends here:

g++ -c -DPERL_CORE -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_FORTIFY_SOURCE=2 -O2 -Wall -Werror=pointer-arith -Werror=vla -Wextra -Wno-long-long -Wwrite-strings peep.c
peep.c: In function 'void Perl_rpeep(OP*)':
peep.c:3897:14: error: jump to case label
 3897 |         case OP_AASSIGN: {
      |              ^~~~~~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
peep.c:4004:14: error: jump to case label
 4004 |         case OP_REF:
      |              ^~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
peep.c:4005:14: error: jump to case label
 4005 |         case OP_BLESSED:
      |              ^~~~~~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
peep.c:4013:14: error: jump to case label
 4013 |         case OP_LENGTH:
      |              ^~~~~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
peep.c:4022:14: error: jump to case label
 4022 |         case OP_POS:
      |              ^~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
peep.c:4028:14: error: jump to case label
 4028 |         case OP_CUSTOM: {
      |              ^~~~~~~~~
peep.c:3844:17: note:   crosses initialization of 'OP* lval'
 3844 |             OP* lval = cBINOPx(o)->op_last;
      |                 ^~~~
peep.c:3843:17: note:   crosses initialization of 'OP* rhs'
 3843 |             OP* rhs = cBINOPx(o)->op_first;
      |                 ^~~
*** Error code 1

Stop.
make: stopped in /usr/home/jkeenan/gitwork/perl

jkeenan · 2022-08-17T14:43:04Z

And, no surprise, clang++ builds are breaking as well. Here's one on OpenBSD.

jkeenan · 2022-08-17T16:24:22Z

A recent commit to blead has broken the build when using g++ as the C-compiler.

I first noticed this breakage in recent smoke-test reports such as this one.

Correction for copy/paste error noted by Bram:
http://perl.develop-help.com/raw/?id=284149

Code in 9fdd7fc broke the g++ builds, Basically what the code looked like: switch (o->op_type) { ... case OP_SASSIGN: ... OP* rhs = cBINOPx(o)->op_first; OP* lval = cBINOPx(o)->op_last; ... break; case OP_AASSIGN: { g++ does not allow this and errors with: peep.c:3897:14: error: jump to case label 3897 | case OP_AASSIGN: { | ^~~~~~~~~~ peep.c:3844:17: note: crosses initialization of 'OP* lval' 3844 | OP* lval = cBINOPx(o)->op_last; | ^~~~ peep.c:3843:17: note: crosses initialization of 'OP* rhs' 3843 | OP* rhs = cBINOPx(o)->op_first; | ^~~ This happens because `rhs` and `lval` are not scoped in the case statement so it could fall through to the next case. The solution is to scope them which this commit now does by adding a separate scope for `OP_SASSIGN` (similar to `OP_AASSIGN). Fixes Perl#20108

Code in 9fdd7fc broke the g++ builds, Basically after the commit the code looked like: switch (o->op_type) { ... case OP_SASSIGN: ... OP* rhs = cBINOPx(o)->op_first; OP* lval = cBINOPx(o)->op_last; ... break; case OP_AASSIGN: { g++ does not allow this and errors with: peep.c:3897:14: error: jump to case label 3897 | case OP_AASSIGN: { | ^~~~~~~~~~ peep.c:3844:17: note: crosses initialization of 'OP* lval' 3844 | OP* lval = cBINOPx(o)->op_last; | ^~~~ peep.c:3843:17: note: crosses initialization of 'OP* rhs' 3843 | OP* rhs = cBINOPx(o)->op_first; | ^~~ This happens because `rhs` and `lval` are not scoped in the case statement so it could fall through to the next case. The solution is to scope them which this commit now does by adding a separate scope for `OP_SASSIGN` (similar to `OP_AASSIGN). Fixes Perl#20108

Code in 9fdd7fc broke the g++ builds, Basically after the commit the code looked like: switch (o->op_type) { ... case OP_SASSIGN: ... OP* rhs = cBINOPx(o)->op_first; OP* lval = cBINOPx(o)->op_last; ... break; case OP_AASSIGN: { g++ does not allow this and errors with: peep.c:3897:14: error: jump to case label 3897 | case OP_AASSIGN: { | ^~~~~~~~~~ peep.c:3844:17: note: crosses initialization of 'OP* lval' 3844 | OP* lval = cBINOPx(o)->op_last; | ^~~~ peep.c:3843:17: note: crosses initialization of 'OP* rhs' 3843 | OP* rhs = cBINOPx(o)->op_first; | ^~~ This happens because `rhs` and `lval` are not scoped in the case statement so it could fall through to the next case. The solution is to scope them which this commit now does by adding a separate scope for `OP_SASSIGN` (similar to `OP_AASSIGN`). Fixes Perl#20108

Code in 9fdd7fc broke the g++ builds, Basically after the commit the code looked like: switch (o->op_type) { ... case OP_SASSIGN: ... OP* rhs = cBINOPx(o)->op_first; OP* lval = cBINOPx(o)->op_last; ... break; case OP_AASSIGN: { g++ does not allow this and errors with: peep.c:3897:14: error: jump to case label 3897 | case OP_AASSIGN: { | ^~~~~~~~~~ peep.c:3844:17: note: crosses initialization of 'OP* lval' 3844 | OP* lval = cBINOPx(o)->op_last; | ^~~~ peep.c:3843:17: note: crosses initialization of 'OP* rhs' 3843 | OP* rhs = cBINOPx(o)->op_first; | ^~~ This happens because `rhs` and `lval` are not scoped in the case statement so it could fall through to the next case. The solution is to scope them which this commit now does by adding a separate scope for `OP_SASSIGN` (similar to `OP_AASSIGN`). Fixes #20108

jkeenan · 2022-08-18T17:24:35Z

Repair confirmed with a build on FreeBSD with this invocation:

$ sh ./Configure -des -Dusedevel -Duseithreads -Dcc=g++ && make test_harness

Code in 9fdd7fc broke the g++ builds, Basically after the commit the code looked like: switch (o->op_type) { ... case OP_SASSIGN: ... OP* rhs = cBINOPx(o)->op_first; OP* lval = cBINOPx(o)->op_last; ... break; case OP_AASSIGN: { g++ does not allow this and errors with: peep.c:3897:14: error: jump to case label 3897 | case OP_AASSIGN: { | ^~~~~~~~~~ peep.c:3844:17: note: crosses initialization of 'OP* lval' 3844 | OP* lval = cBINOPx(o)->op_last; | ^~~~ peep.c:3843:17: note: crosses initialization of 'OP* rhs' 3843 | OP* rhs = cBINOPx(o)->op_first; | ^~~ This happens because `rhs` and `lval` are not scoped in the case statement so it could fall through to the next case. The solution is to scope them which this commit now does by adding a separate scope for `OP_SASSIGN` (similar to `OP_AASSIGN`). Fixes Perl#20108

jkeenan added the Needs Triage label Aug 17, 2022

bram-perl mentioned this issue Aug 17, 2022

Fix g++ build (Add extra scope block for switch case) #20109

Merged

khwilliamson closed this as completed in #20109 Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9fdd7fc479 breaks build using g++ as compiler #20108

9fdd7fc479 breaks build using g++ as compiler #20108

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 18, 2022

9fdd7fc479 breaks build using g++ as compiler #20108

9fdd7fc479 breaks build using g++ as compiler #20108

Comments

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 17, 2022

jkeenan commented Aug 18, 2022