-
Notifications
You must be signed in to change notification settings - Fork 577
perl5.005_02: my_setenv() and Term::ReadLine::Gnu #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From [Unknown Contact. See original ticket]Joerg Schumacher writes:
Without further explanation I hardly think this is a solution. The Note that malloc.c of 5.005_62 already includes Perl_putenv(). Since #if POLLUTE... ). I think this (and possibly strdup(), Ilya |
From [Unknown Contact. See original ticket]Hello Joerg, and long time no seeing you, Ilya. Ilya> Without further explanation I hardly think this is a solution. The I agree with you. Something wrong around malloc(). But I feel strange by seeing the patch.
The orignal code assumes
is true, only when my_setenv() is called at the first time only. And Thank you. Hiroo Hayashi |
From [Unknown Contact. See original ticket]On Wed, Nov 17, 1999 at 11:59:01PM +0100, Joerg Schumacher wrote:
How does it assume it? Do you try to imply that environ may be Ilya |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 12:24:05AM +0100, Joerg Schumacher wrote:
*What* it calls Safefree() on? How can it be that this is unallocated? I think you need to concentrate on these questions. Ilya |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 01:08:34AM +0100, Joerg Schumacher wrote:
You look utterly confused. First you claim that this is not a problem Please decide which way you want to argue first. All you write Ilya |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 01:31:11AM +0100, Joerg Schumacher wrote:
OK, now it is us who look utterly confused... I was pretty sure that So your solution involves a static variable. Hmm... Since But nevertheless, your solution is a leak, since the environment set Ilya |
From [Unknown Contact. See original ticket]%% Ilya Zakharevich <ilya@math.ohio-state.edu> writes: iz> OK, now it is us who look utterly confused... I was pretty sure No, it doesn't. For one thing, there's no requirement that the memory iz> but most probably it just leaks... If you pass it an alloc'ed block and don't save a pointer to it yourself putenv() is a crappy function. -- Paul D. Smith <psmith@baynetworks.com> Network Management Development These are my opinions---Nortel Networks takes no responsibility for them. |
From [Unknown Contact. See original ticket]Joerg Schumacher writes:
Let me restate things to syncronize our understanding: a) Perl uses PL_origenviron variable to understand when environ is malloc()ed. You do not claim that this scheme is broken (though AFAICS, it will b) Perl thinks that if environ is malloc()ed, then environ[i] is malloc()ed; You claim that this assumption is unwarranted. This claim looks correct. However, in view of the above two statements your patch is still Ilya |
From [Unknown Contact. See original ticket]On Fri, 19 Nov 1999, Joerg Schumacher wrote: <--- my_setenv() problem ---> Maybe I should have piped in before, but I think someone else has Rasmus
Rasmus.Tamstorf@disney.com "A problem worthy of attack, |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 01:37:35AM +0100, Joerg Schumacher wrote:
I do not believe this. At least the documentation I see states that Ilya |
From [Unknown Contact. See original ticket]
So what? It's only documentation, "peppered with wishful thinking, --tom |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 07:14:08PM -0700, Tom Christiansen wrote:
It was C topic. C is a programming language. Programming languages Hope this helps, |
From [Unknown Contact. See original ticket]
Oh. I didn't realize Perl wasn't a programming language. I'm pretty --tom |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 07:34:36PM -0700, Tom Christiansen wrote:
You know perfectly well that Perl is not up to this category yet. Ilya |
From [Unknown Contact. See original ticket]On Thu, 18 Nov 1999 22:22:57 -0500
I know absolutely no such thing, and I challenge you to spell out very Perl is a programming language. Finis. --tom |
From [Unknown Contact. See original ticket]On Thu, Nov 18, 1999 at 08:24:29PM -0700, Tom Christiansen wrote:
Says the same guy who claims that calling shell has no significant Yeah, right... Ilya |
From @ysthIn article <19991118210401.A16532@monk.mps.ohio-state.edu>,
Single UNIX V2 seems to say otherwise. In particular it states that Sad. Makes putenv extremely unattractive. |
From [Unknown Contact. See original ticket]Yitzchak Scott-Thoennes writes:
We are not discussing environ[i] here, we are discussing environ Ilya |
From [Unknown Contact. See original ticket]Yitzchak Scott-Thoennes <sthoenna@efn.org> writes:
Solaris7 still says that : DESCRIPTION Thus one must malloc the string. static char *myvar = "HOME=/some/place"; Thus as far as I can see unless we keep a hash of "things we malloc'ed" -- |
From [Unknown Contact. See original ticket]Quoting ilya@math.ohio-state.edu: And your point is exactly?... How do you define a "programming language"? For me, it's a language I Up to now: for (my $i = 0; $i < 10; $i++) { has never failed to produce its expected output. And that's only one Perl IS a programming language. Period! The mere fact that we even NEED to ARGUE about this is a sure sign that Raphael |
From [Unknown Contact. See original ticket]Nick Ing-Simmons <nik@tiuk.ti.com> wrote
Exactly. And therefore, since we don't want memory leaks, we must What would happen about changes to %ENV from XS code? Or would the magic Mike Guy |
From [Unknown Contact. See original ticket]On Fri, 19 Nov 1999, M.J.T. Guy wrote:
You just have to be careful about that when you're embedding perl in Another problem (which is biting me :-( is that the practice of assigning Rasmus Rasmus Tamstorf (tamstorf@fa.disney.com) If you can dream it you can do it ! |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 10:14:21AM +0100, Raphael Manfredi wrote:
Approximately: "Do not finis me!" ;-)
Yes. You cannot in Perl, since only 60% or so of operations are $a = $b + $c; ? Ilya |
From [Unknown Contact. See original ticket]
You keep saying that. Please back it up with exact cites. It sounds (if you omit those things which are documented hopelessly
I for one am sick and tired of listening to you cast aspersions on the
Why yes. I did. Assuming unoverloaded and numeric operands, I expect --tom |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 10:55:04AM -0700, Tom Christiansen wrote:
What makes you expect this? Ilya |
From [Unknown Contact. See original ticket]
History. Culture. Precedent. Sanity. |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 10:57:50AM -0700, Tom Christiansen wrote:
I see. Anything but not documentation. ;-) I would call it guesswork. Now please explain what your guesswork will do with "as respectively Got the trend? Ilya |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 07:04:33PM +0100, Joerg Schumacher wrote:
Please read what I wrote. Ilya |
From [Unknown Contact. See original ticket]
No, I don't. I want you to take the time to spell these things out. --tom |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 11:06:19AM -0700, Tom Christiansen wrote:
Are you infering that I do not? And please explain how printf(3) Ilya |
From [Unknown Contact. See original ticket]
That's exactly the problem, Ilya. Don't be so smug about it. --tom |
From [Unknown Contact. See original ticket]
I infer nothing, and as to what I imply, I prefer not to do that I shall state it again plainly: At a bare minimum, stop insulting us by
I believe that following in your footsteps, the expected response Oh. You do mind? I don't blame you. So do the rest of us. well. The answer is that Perl's printf function is directly descended --tom |
From [Unknown Contact. See original ticket]Tom Christiansen writes:
Do you propose to spell things out for people who did not read what I Ilya |
From [Unknown Contact. See original ticket]
Yup. Sometimes rephrasing, reminders, and even repetition is essential to Feel free to correct me if that assumption (clear communication) has --tom |
From [Unknown Contact. See original ticket]Tom Christiansen writes:
Do not "be silent" me.
Are you infering that I do not? And given the treatement my doc
I see. So one needs to apply guesswork to understand what "proves You see, all your answers show that Perl is a good scripting language, Ilya |
From [Unknown Contact. See original ticket]Tom Christiansen writes:
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/1999-11/msg00678.html Ilya |
From [Unknown Contact. See original ticket]
Wrong answer. I see no rephrasing. I see no communiation. Thank you --tom |
From [Unknown Contact. See original ticket]
Very well, then explain then what useful purpose is served by your
(Note for non-native speaker: imply and infer, like teach and learn, I am implying nothing. I am stating that your insults on the Perl And frankly, I in complete honesty cannot recall a recent instance in
This is going nowhere. Is that your goal? Congratulations, you're
There you go again with that "not a real programming language crap". --tom |
From [Unknown Contact. See original ticket]On Fri, 19 Nov 1999, Tom Christiansen wrote:
Not documentation? Can't Tom and Ilya agree to disagree? Can't Ilya be ignored when it's -Aaron |
From [Unknown Contact. See original ticket]On Fri, 19 Nov 1999, Tom Christiansen wrote:
I know you're some kind of linguistic expert (or at least have had some I'm sure you'll now tell me how I've used the word "beknownst" -Aaron |
From [Unknown Contact. See original ticket]
Most of my formal training was in various discrete languages, with only a
Yes, you can both be the teacher and the learner, the implyer and the
Although I would have just used "known" in that case, at least in most % grep 'beknow' /usr/dict/words And the 'nst$' pattern isn't very common either: % grep 'nst$' /usr/dict/words But I'm not one to get pwittertated about inventful and amusing coinings, --tom |
From [Unknown Contact. See original ticket]
Could you please explain to a non-native the 'st' suffix meaning ? Thank you, François |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 01:52:57PM -0500, ajm6q@virginia.edu wrote:
Do not suggest this. This road leads to hell even faster than our
Yes. -- |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 01:52:57PM -0500, Aaron J Mackey wrote:
No, they're hashing out langauge features (or misfeatures).
"it"? But yes, anyone can be ignored.
As *I* see it, Tom isn't "putting down" anyone's ideas as much as he's -Scott |
From [Unknown Contact. See original ticket]
Hm... that's a good question. Certainly its most common modern usage is as part of the superlative It's also a marker for the preterite when "-ed" has gone to "t". Historically, (well, archaically or poetically; same diff :-), the But "unbeknownst" would not appear to be of any of those categories, and To my ear, the "-st" up in "unbeknownst" lends an certain air of erudition --tom |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 12:16:09PM -0700, Tom Christiansen wrote:
Correct. And thanks for your correction. Ilya |
From [Unknown Contact. See original ticket]On Fri, Nov 19, 1999 at 11:41:51AM -0700, Tom Christiansen wrote:
Hmm... Do you? If not, why? Apparently you subscribe to a
Nope. That's diagnosis, which is one of the necessary steps on the
Please do not "it has no business being said" me. Thanks. Ilya |
From @gsarOn Fri, 19 Nov 1999 13:52:57 EST, Aaron J Mackey wrote:
Bad attitude is like a conspicuous fart. The culprit can't help it, Deeds matter, words not. Sarathy |
From [Unknown Contact. See original ticket]duff@cbi.tamucc.edu:
I'd much prefer that these were Perl language features, not -- |
From [Unknown Contact. See original ticket]Tom Christiansen <tchrist@jhereg.perl.com> writes:
OED2 thinks so too: " OED2 does have 'beknownst' but has beknow as obsolete.
Sounds like fake "Olde Englishe" to me ;-) -- |
As also stated in the stdlib documentation, setenv() is a bit of a dangerous interface and can cause a lot of headaches. For instance, perl before version 5.38 (at the time of writing, debian stable (bookworm) uses version 5.36) manipulates the `environ` pointer directly. When calling rust (or any other language) code from perl via bindings, calling `setenv` easily leads to crashes[2]. In perl 5.38 this was fixed [1] and perl should itself also stick to using `setenv`. This improves the situation a lot and leaves only the threading issue we cannot solve here. This commit allows the perl code to preset the environment variables to avoid at least this instance of setenv causing crashes. See-also: Perl/perl5#339 See-also: Perl/perl5#859 See-also: [1] Perl/perl5@916a038 See-also: [2] https://bugzilla.proxmox.com/show_bug.cgi?id=4979 Signed-off-by: Wolfgang Bumiller <[email protected]>
Migrated from rt.perl.org#1789 (status was 'resolved')
Searchable as RT1789$
The text was updated successfully, but these errors were encountered: