Skip to content

study_chunk: avoid transforming ops while enframed #17715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

hvds
Copy link
Contributor

@hvds hvds commented Apr 12, 2020

gh16947: the outer frame may be in the middle of looking at the part
of the program we would rewrite. Let the outer frame deal with it.

gh16947: the outer frame may be in the middle of looking at the part
of the program we would rewrite. Let the outer frame deal with it.
@xsawyerx
Copy link
Member

We can merge this.

@khwilliamson khwilliamson merged commit bdb91f3 into blead Apr 15, 2020
@khwilliamson khwilliamson deleted the gh16947-2 branch April 15, 2020 20:08
@dur-randir
Copy link
Member

This commit introduced the following regression:

./miniperl -e 'm$ss++$i for s0'

now panic()'s with

regrepeat() called with unrecognized node type 53='EXACTFU_S_EDGE'

@xsawyerx @hvds @khwilliamson

@hvds
Copy link
Contributor Author

hvds commented Apr 18, 2020

Confirmed, looks like SUSPEND may use framing recursion inconsistently. Looking into it now.

@hvds
Copy link
Contributor Author

hvds commented Apr 18, 2020

I've reopened #16947 and put further information there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants