regcomp.c: incr ref cnt of re_intuit_string() return #17763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvds
reviewed
Apr 29, 2020
khwilliamson
force-pushed
the
smoke-me/khw-17734
branch
from
449cda1 to
f9dd299
Compare
|
Looks good to me; I think you could simplify slightly by setting In the commit message s/should not freed/should not be freed/. |
It turns out that the SV returned by re_intuit_string() may be freed by future calls to re_intuit_start(). Thus, the caller doesn't get clear title to the returned SV. (This wasn't documented until the commit immediately prior to this one.) Cope with this situation by making a mortalized copy. This commit also changes to use the copy's PV directly, simplifying some 'if' statements. re_intuit_string() is effectively in the API, as it is an element in the regex engine structure, callable by anyone. It should not be returning a tenuous SV. That returned scalar should not freed before the pattern it is for is freed. It is too late in the development cycle to change this, so this workaround is presented instead for 5.32. This fixes #17734.
khwilliamson
force-pushed
the
smoke-me/khw-17734
branch
from
f9dd299 to
4d36401
Compare
|
Good point. Changed to that |
xsawyerx
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function returns an SV that it turns out may have its reference
count decremented by a future call to re_intuit_start(). Thus, the
caller doesn't get clear title to the returned SV. This is not
documented.
It is too late in the development cycle to properly fix this, but in
this instance, it is a simple matter to increment the ref count of the
returned scalar
This fixes #17734.