Replace ssh with https

[ghost]

Modify the git remote add fork argument in perlhack.pod.

[Grinnz]

Why?

This part of the documentation is describing your personal fork, which you need to set up with write access.

[ghost]

SSH URLs are not mentioned in perlhack.pod.

617d9ec#diff-fbf8c7e20f85f9aacf05c038ed8c687d
Update perlgit and perlhack to reference GitHub pull request workflow
khwilliamson committed Oct 24, 2019

perlhack.pod

-  % git format-patch -1
-  % ./perl -Ilib utils/perlbug -p 0001-*.patch
+  % git remote add fork [email protected]:MyUser/perl5.git

A git protocol clone was previously replaced with an https clone.

47ef154#diff-fbf8c7e20f85f9aacf05c038ed8c687d
Update documentation, comments, metadata to reference GitHub as canon…
toddr committed Oct 20, 2019

perlhack.pod

-  % git clone git://perl5.git.perl.org/perl.git perl
+  % git clone https://github.com/Perl/perl5.git perl

[Grinnz]

That does not answer the question.

[Leont]

Different people have different preferences. I can see the argument for mentioning both ways, but simply changing it to your preference seems like an unfortunate move.

[Grinnz]

It is not a preference. The remote added for your personal fork must have write access.

[xenu]

You can have write access via https, github supports that.

[Grinnz]

Only via explicit credentials, but I suppose if you want to explain both that option and ssh keys.

[Grinnz]

If you want to mention both options, it would be best to link to https://docs.github.com/en/free-pro-team@latest/github/using-git/which-remote-url-should-i-use and indicate that authentication with either SSH keys or personal access token is required to push to your private fork.

[ghost]

Create a GitHub fork of the perl5 repository and add it as a remote, if you haven't already, as described in the GitHub documentation at https://help.github.com/en/articles/working-with-forks.

% git remote add fork [email protected]:MyUser/perl5.git

For more information, see "Connecting to GitHub with SSH".

If you'd rather use an HTTPS URL for your git push see "Cloning with HTTPS URLs".

% git remote add fork https://github.com/MyUser/perl5.git

Then, push your new branch to your fork.

[Grinnz]

The current addition is reasonable.

[atoomic]

LGTM, at least this leaves the choice to the user to use ssh or https :-)

[ghost]

Opening this ticket was not a matter of personal preferences.

When creating a repository via GitHub's menu subsequent instructions use HTTPS URLs.