-
Notifications
You must be signed in to change notification settings - Fork 577
perlxstut add links and update examples #18240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why is perl 5.22.2 needed? Could the commit message be a little more self-explanatory? |
In general it is counter-productive to include unrelated unexplained changes. |
The define The define Perl |
3 failing checks after bb321ad. testsuite / Windows msvc142 |
@apparluk May I ask why you closed this PR and deleted the branch? |
[doc] perlxs rpc (also Closed) Here are the two files if someone else wants to take up the work. Gist Contains your code changes (the last all tests passing) and Gist Run rpctest.pl and verify the correctness of the output before merging. I have mostly moved on from this document. Please feel free to make whatever changes you feel are necessary to keep it up to date, or expand it as much as you like. |
cf: #18240 (comment) I used 5.017007 in the .pod believing PERL_NO_GET_CONTEXT first appeared in that release. - use 5.008008;
+ use 5.017007; However it would be unusual to expose the reader to a development release of perl in the .pod, and maybe using instead the >5.017007 next stable perl version would be more sensible. cf: #18240 (comment) The first failed tests on this PR occurred after bb321ad (Nov 1, 2020, 2:31 AM GMT+1). |
The failing tests are unrelated to the commits in this PR, see #18280 |
This PR's msvc fails had the error message citing an unresolved external symbol. |
This comment has been minimized.
This comment has been minimized.
Keep the append instruction and leave SPECIAL NOTES Possible expansion could add a subsection on |
For #18163.