Skip to content

Make clear Fatal is still not OK #18385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make clear Fatal is still not OK #18385

wants to merge 1 commit into from

Conversation

jidanni
Copy link
Member

@jidanni jidanni commented Dec 6, 2020

Otherwise people will think we are publishing the final OK accepted way!
Perhaps also note there is still no OK accepted way.

Otherwise people will think we are publishing the final OK accepted way!
Perhaps also note there is still no OK accepted way.
@jidanni
Copy link
Member Author

jidanni commented Dec 6, 2020

Not that we still don't recommend it

s/Not/Note/

@Grinnz
Copy link
Contributor

Grinnz commented Dec 6, 2020

This already seems clear in context to me, since this follows all of the caveats in the text.

@jidanni
Copy link
Member Author

jidanni commented Dec 6, 2020

This already seems clear in context to me, since this follows all of the caveats in the text.

No. Compare perlvar:

       In Perl 5.20.0 a new copy-on-write system was enabled by default, which
       finally fixes all performance issues with these three variables, and
       makes them safe to use anywhere.

So you still need to remind the user that this (new way to write FATAL) doesn't fix anything.
But do please rephrase it. I am a bad writer.

@jkeenan
Copy link
Contributor

jkeenan commented Jan 30, 2021

Addressed in commit 01900a5. Closing ticket.

@jkeenan jkeenan closed this Jan 30, 2021
Corion pushed a commit to Corion/perl5 that referenced this pull request Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants