Fix up subsystem termination order #18439
Closed
+32
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would expect |
|
@khwilliamson , @Leont, Can we get an update on the status of this p.r.? Thank you very much. |
|
Yes,
mymalloc uses PerlIO under -Dm (which is probably a bug.) |
khwilliamson
force-pushed
the
smoke-me/khw-pr4
branch
from
f5177af to
cdaaa15
Compare
The IO and memory terminations need to be after other things. Add a comment so that future maintainers won't make the mistakes I did. Also refactor to that amiga os doesn't have a separate list to get out of sync I suspect that the amiga termination should be moved to earlier in the sequence, but absent any evidence; I'm leaving it unchanged.
khwilliamson
force-pushed
the
smoke-me/khw-pr4
branch
from
cdaaa15 to
0105cf9
Compare
khwilliamson
changed the title
Leont
reviewed
Feb 11, 2021
|
|
||
| #ifndef PERL_SYS_TERM_BODY |
There was a problem hiding this comment.
I think we still need this #ifdef. There are several operating systems that still define their own PERL_SYS_INIT_BODY (plan9, dos, vms, os2).
Maybe this can be refactored into some OS_SYS_INIT_, I haven't looked into potential ordering issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During destruction, a list is executed in order. Here's a couple of
them:
OP_CHECK_MUTEX_TERM; OP_REFCNT_TERM;
If something goes wrong, and the I/O system has already been destructed,
it's hard to figure out what's going on. This is solved simply by
moving the I/O termination to the end of the list.