pp_split: calculate flags just once and other minor tweaks #18526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardleach
force-pushed
the
hydahy/pp_split-notrailing_empty
branch
from
500c4b9 to
0d6ea91
Compare
richardleach
force-pushed
the
hydahy/pp_split-notrailing_empty
branch
from
0d6ea91 to
a080eee
Compare
richardleach
added
awaiting review
and removed
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR:
newSVpvn_flagsjust once, rather than at every call.realarraya bool, rather than an I32.multilineto the only branch that actually uses it.These changes result in a smaller pp.o, although not a smaller miniperl/perl (with gcc at -O2).
Simple benchmarks on x64 Linux don't show a change to run time performance.