Smoke me/jkeenan/gh 18570 t op magic #18571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start by standardizing leading whitespace For: #18570
For GH 18570
tomhukins
approved these changes
Feb 15, 2021
|
I'm hoping to get some smoke-test results on Dragonfly BSD. Once those are in, I will merge this p.r. and close the parent ticket. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomhukins, with this patch
t/op/magic.tonce again PASSes on FreeBSD-12 when invoked via./miniperl -Ilib t/op/magic.tand duringmake minitest. It continues to pass when run with./perl.However, your inline comments suggest that this might need to be tested on other (older ?) FreeBSDs and on Dragonfly BSD. Can you review?
For: #18570
Thank you very much.
Jim Keenan