Skip to content

mg.c: Silence compiler warning #18649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

mg.c: Silence compiler warning #18649

wants to merge 1 commit into from

Conversation

khwilliamson
Copy link
Contributor

This was generating

warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]

This was generating

warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
@jkeenan
Copy link
Contributor

jkeenan commented Mar 17, 2021

This was generating

warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]

Could you provide the OS, perl -V:config_args and C-compiler info for the warnings you are trying to silence?

Spot-checking my recent builds, I don't see any warnings associated with mg.c.

Thank you very much.
Jim Keenan

@khwilliamson
Copy link
Contributor Author

khwilliamson commented Mar 18, 2021 via email

@jkeenan
Copy link
Contributor

jkeenan commented Mar 18, 2021

On 3/17/21 4:08 PM, James E Keenan wrote: This was generating warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] Could you provide the OS, |perl -V:config_args| and C-compiler info for the warnings you are trying to silence? Spot-checking my recent builds, I don't see any warnings associated with |mg.c|.
Summary of my perl5 (revision 5 version 33 subversion 8) configuration: Commit id: bbb5866 Platform: osname=linux osvers=5.4.0-66-generic archname=x86_64-linux-thread-multi uname='linux khw-xps-8930 5.4.0-66-generic #74-ubuntu smp wed jan 27 22:54:38 utc 2021 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Uversiononly -Dprefix=/home/khw/blead -Dusedevel -Doptimize=-O0 -DDEBUGGING -A'optimize=-ggdb3' -Accflags='-Wno-deprecated' -Dman1dir='none' -Dman3dir='none' -Dcc=g++ -Dusecbacktrace -Dusethreads'

Thanks. I compiled perl on FreeBSD-12 using g++-9.3.0 as the C-compiler. On blead I got:

[perlmonger: make-output] $ ~/bin/perl/report-build-warnings 50e8f677c3.freebsd.g++-9.3.0.maketp.output.txt 
File:  50e8f677c3.freebsd.g++-9.3.0.maketp.output.txt

  Wempty-body                                6
  Wignored-qualifiers                        4
  Wimplicit-fallthrough=                     4
  Wmissing-field-initializers                7
  Wpragmas                                   2

In your branch I got:

$ ~/bin/perl/report-build-warnings ab3cb04e2a.freebsd.g++-9.3.0.maketp.output.txt.gz 
File:  ab3cb04e2a.freebsd.g++-9.3.0.maketp.output.txt.gz

  Wempty-body                                6
  Wignored-qualifiers                        2
  Wimplicit-fallthrough=                     4
  Wmissing-field-initializers                7
  Wpragmas                                   2

So those two warnings in mg.c have been eliminated. I will merge the branch.

Thank you very much.
Jim Keenan

@jkeenan jkeenan closed this Mar 18, 2021
@jkeenan jkeenan deleted the khw/pr6 branch March 18, 2021 11:38
@jkeenan jkeenan added the build-time-warnings Replaces [META] Build-time warnings RT #133556 label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-time-warnings Replaces [META] Build-time warnings RT #133556
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants