Fix regex sets pod to handle more /flags, and update pod #19459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you point us to places in the test suite which exercise the code whose documentation needs adjusting? |
|
On 2/24/22 13:34, James E Keenan wrote:
The pod didn't reflect restrictions on what can go into such a class.
Can you point us to places in the test suite which exercise the code
whose documentation needs adjusting?
t/re /reg_mesg.t
/regex_sets.t
/regex_sets_compat.t
|
The pod didn't reflect restrictions on what can go into such a class.
See Perl#16779 (comment) This commit extends the flags accepted by nested calls to regex sets to any legal set. Previously it allowed only '^', as that is what an actual compilation would return. But as pointed out in the conversation in that ticket, it's possible to detach flags from the rest of the pattern, and to write equivalent ones in multiple ways. This commit just changes one line to look for any legal flag, not restricting it to '^'.
khwilliamson
force-pushed
the
pr_api4
branch
from
b19af80 to
8790b7c
Compare
khwilliamson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pod didn't reflect restrictions on what can go into such a class.