switch_locale_context: Add aTHX #21072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
May 3, 2023
locale.c
Outdated
| @@ -7219,10 +7219,7 @@ Perl_switch_locale_context() | |||
|
|
|||
| /* Can't use pTHX, because we may be called from a place where that | |||
There was a problem hiding this comment.
Why does this comment say "Can't use pTHX" if the function now uses pTHX?
There was a problem hiding this comment.
Because I made a mistake; now fixed
This fixes GH Perl#21040 Instead of a dTHX, this passes aTHX automatically, and skips calling this function if there is no valid context. It moves that decision into the macro itself.
|
This doesn't work on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GH #21040
Instead of a dTHX, this passes aTHX automatically, and skips calling this function if there is no valid context.
It moves that decision into the macro itself, avoiding some #ifdef directives.