Skip to content

skip leaking test in class feature #21104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023
Merged

skip leaking test in class feature #21104

merged 1 commit into from
May 19, 2023

Conversation

iabyn
Copy link
Contributor

@iabyn iabyn commented May 19, 2023

This test is known to leak: see GH #20812. Skip it for now so that ASAN smokes don't fail. Start failing again on the next development branch so that the issue isn't forgotten

This test is known to leak: see GH #20812. Skip it for now so that ASAN
smokes don't fail. Start failing again on the next development branch so
that the issue isn't forgotten
Copy link
Contributor

@leonerd leonerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkeenan
Copy link
Contributor

jkeenan commented May 19, 2023

Configuring in blead with these arguments:

$ sh ./Configure -des -Dusedevel -Dcc=clang -Accflags="-g -fno-omit-frame-pointer -fsanitize=address  -fno-common -fsanitize-blacklist=`pwd`/asan_ignore" -Aldflags="-fsanitize=address"

... I then ran the test file:

$ cd t;PERL_DESTRUCT_LEVEL=2 ./perl harness ./lib/croak.t; cd -

... and confirmed the test failure.

I then switched to davem/skip_croak, repeated the process, and confirmed that the failing test is now skipped. Merging.

@jkeenan jkeenan merged commit 5a3ae03 into blead May 19, 2023
@jkeenan jkeenan deleted the davem/skip_croak branch May 19, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants