Add CI entry for static Perl #22052
Merged
Add CI entry for static Perl #22052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself looks fine, if it was inspired by some sort of issue, like the |
No it was the other way around, the re build/test issues were discovered when I wrote this patch. |
Ok, I though it might have been inspired by #21550 |
tonycoz
approved these changes
Mar 6, 2024
bltavares
added a commit
to bltavares/nixpkgs-upstream
that referenced
this pull request
Mar 28, 2024
This commit backports a commit introduced on Perl 5.39.2 to allow `pkgs.pkgsStatic.perl` to compile without raising errors about duplicate symbols being defined during the linking process. This fixes NixOS#295608 | Tested on | Status | | --- | --- | | M1 Mac (aarch64-darwin) | Failed due to other issues* | | NixOS VM (x86_64-linux) | Compiled | | Nix (aarch64-linux) | Compiled | **Test method**: ```sh nix repl -I nixpkgs=$PWD nix repl> pkgs = import <nixpkgs> {} nix repl> :b pkgs.perl nix repl> :b pkgs.pkgsStatic.perl ``` Despite the upstream commit being scoped to all environments, we are only applying this patch only on the `pkgsStatic` context to avoid rebuilding all of NixOS packages by changing Perl. It includes an additional build flag [also used upstream](Perl/perl5#22052) for configuring static builds. *MacOS: `pkgsStatic.perl` still fails to compile after this change due to MacOS case-insensitiviness affecting the build recipe under /tmp, as `perl-cross/configure` is copied over `perl/Configure` file, as well as not finding `readelf` for the `configurePhase`. NixOS#113985 (comment) NixOS/nix#1446 NixOS/nix#9318 NixOS/nix#8995
13 tasks
bltavares
added a commit
to bltavares/nixpkgs-upstream
that referenced
this pull request
Apr 1, 2024
This commit backports a commit introduced on Perl 5.39.2 to allow `pkgs.pkgsStatic.perl` to compile without raising errors about duplicate symbols being defined during the linking process. This fixes NixOS#295608 | Tested on | Status | | --- | --- | | M1 Mac (aarch64-darwin) | Failed due to other issues* | | NixOS VM (x86_64-linux) | Compiled | | Nix (aarch64-linux) | Compiled | **Test method**: ```sh nix repl -I nixpkgs=$PWD nix repl> pkgs = import <nixpkgs> {} nix repl> :b pkgs.perl nix repl> :b pkgs.pkgsStatic.perl ``` Despite the upstream commit being scoped to all environments, we are only applying this patch only on the `pkgsStatic` context to avoid rebuilding all of NixOS packages by changing Perl. It includes an additional build flag [also used upstream](Perl/perl5#22052) for configuring static builds. *MacOS: `pkgsStatic.perl` still fails to compile after this change due to MacOS case-insensitiviness affecting the build recipe under /tmp, as `perl-cross/configure` is copied over `perl/Configure` file, as well as not finding `readelf` for the `configurePhase`. NixOS#113985 (comment) NixOS/nix#1446 NixOS/nix#9318 NixOS/nix#8995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.