perl5db.pl: "c subname" and "b subname" break on first executable line if possible #22379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Jul 4, 2024
tonycoz
force-pushed
the
799-break-first-sub-line
branch
from
8c516c3 to
041b13c
Compare
|
What I pushed last week was a bit undercooked. @mauke, thanks for the feedback, I think I've fixed each of the problems you mentioned, and a few more. |
mauke
reviewed
Jul 8, 2024
tonycoz
force-pushed
the
799-break-first-sub-line
branch
from
041b13c to
f83b6ee
Compare
mauke
reviewed
Jul 9, 2024
tonycoz
force-pushed
the
799-break-first-sub-line
branch
from
f83b6ee to
64c8012
Compare
|
Looks good to me. |
This currently doesn't try to handle "b postpone subname" since that internally has an offset function that doesn't really work with this implementation. This is a partial fix for Perl#799
and just plain fix "b postpone subname", which didn't stop at all on my postponed sub test code at all as far back at 5.10. Fixes Perl#799
I've just been looking at the implementation, and there's no test, so add one.
tonycoz
force-pushed
the
799-break-first-sub-line
branch
from
64c8012 to
55eec59
Compare
|
added b postpone support |
mauke
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799