Skip to content

csighandler3: forward signals to the main thread if not a perl thread #22758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Nov 18, 2024

This is only done for pthreads, Win32 already uses something like my suggestion from #22530 and unlike POSIX doesn't have a way to asynchronously interrupt a thread that I'm aware of. It's also complicated by pseudo-processes.

Fixes #22487


  • This set of changes requires a perldelta entry, and it is included.

Perldelta:

On threaded builds on POSIX-like systems, if the perl signal handler receives
we now resend the signal to the main perl thread.  Previously this would
crash.  [GH #22487]

This is only done for pthreads, Win32 already uses something like
my suggestion from Perl#22530 and unlike POSIX doesn't have a way to
asynchronously interrupt a thread that I'm aware of.  It's also
complicated by pseudo-processes.

Fixes Perl#22487
Copy link
Contributor

@khwilliamson khwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'm no expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in Perl_csighandler3 when used XS with threads.
3 participants