Skip to content

Update known POD issues database #23231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Apr 29, 2025

... by running:

cd t; ./perl -I../lib porting/podcheck.t --regen; cd -

This step apparently was missed during recent maintenance and dev releases.


  • This set of changes does not require a perldelta entry.

... by running:

    cd t; ./perl -I../lib porting/podcheck.t --regen; cd -

This step apparently was missed during recent maintenance and dev
releases.
@karenetheridge
Copy link
Member

Something else is going on because make test_porting passes for me and definitely was passing when I released 5.41.11 and 5.41.12.

@jkeenan
Copy link
Contributor Author

jkeenan commented Apr 30, 2025

Something else is going on because make test_porting passes for me and definitely was passing when I released 5.41.11 and 5.41.12.

Agreed. Nonetheless, when I checkout either tag v5.41.12 or HEAD (v5.41.12-22-g9f37e119ab), do my regular configuration and call make test_porting, everything PASSes -- but then when I call cd t; ./perl -I../lib porting/podcheck.t --regen; cd - I get 6 +/- change lines in the diff for t/porting/known_pod_issues.dat.

Copy link
Contributor

@khwilliamson khwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong; I hadn't been paying enough attention to this or to my commit that ended up adding the perldelta entries.

It should not be necessary to regen this data file each release, unless new pod problems get introduced. But that is the point of this test, to alert one to new pod issues, which should be corrected if at all possible. I'll look at podcheck.t and fix it. But this PR should be closed, and I'll revert 1fb05c6

@jkeenan
Copy link
Contributor Author

jkeenan commented Apr 30, 2025

Something else is going on because make test_porting passes for me and definitely was passing when I released 5.41.11 and 5.41.12.

Agreed. Nonetheless, when I checkout either tag v5.41.12 or HEAD (v5.41.12-22-g9f37e119ab), do my regular configuration and call make test_porting, everything PASSes -- but then when I call cd t; ./perl -I../lib porting/podcheck.t --regen; cd - I get 6 +/- change lines in the diff for t/porting/known_pod_issues.dat.

Per further investigation on 5.41.12: This problem occurs both in the repository (tag v5.41.12) and when building from a download tarball.

We get different differences with tag v5.41.10.

@khwilliamson
Copy link
Contributor

Replaced by #23245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants