regexec.c: Use utf8_to_uv_or_die over utf8n_to_uvchr #23560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will now die if the input is malformed. We decided for 5.42 that it is pointless to continue on in pattern matching in the face of malformed input. This was the final occurrence of a to_uvchr() function in this file; the rest were converted for 5.42. This was deferred because of the lateness of the development cycle, and it didn't fix an obvious bug
khwilliamson
force-pushed
the
nregrepeat
branch
from
d7f0155 to
957be9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now die if the input is malformed. We decided for 5.42 that it is pointless to continue on in pattern matching in the face of malformed input. This was the final occurrence of a to_uvchr() function in this file; the rest were converted for 5.42. This was deferred because of the lateness of the development cycle, and it didn't fix an obvious bug