Skip to content

t/run/todo.t: Add test names to tests missing them #23572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

t/run/todo.t: Add test names to tests missing them #23572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions t/run/todo.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ TODO: {
local $^W = $^W;
is($^W, '1', 'local $^W assignment to self ok');
}
is($^W, 1, '$^W value prior to localization is restored');
is($^W, 1, '$^W value prior to localization is restored; GH 5835');
$^W = $prev_w;
}

Expand All @@ -120,10 +120,11 @@ TODO: {
$h->truncate(6) or die $!;
print $x;
EOF
is($?, 0, 'perl exited normally');
is($?, 0, 'perl exited normally; [GH 16008]');

is $results, 'hello ', "truncate returned the expected output";
unlike $results, qr/Bad file descriptor/, "truncate did not warn about bad file descriptors";
is $results, 'hello ', "truncate returned the expected output; [GH 16008]";
unlike $results, qr/Bad file descriptor/,
"truncate did not warn about bad file descriptors [GH 16008]";
}

TODO: {
Expand All @@ -134,36 +135,36 @@ TODO: {
"abcde5678" =~ / b .* (*plb:(*plb:(.{4}))? (.{5}) ) .$ /x;
print $1 // "undef", ":", $2 // "undef", "\n";
EOF
"undef:de567\nundef:de567", { eval $switches }, "");
"undef:de567\nundef:de567", { eval $switches }, "GH 16250");
}

TODO: {
local $::TODO = 'GH 16865';
fresh_perl('\(sort { 0 } 0, 0 .. "a")', { stderr => 'devnull' });
is($?, 0, "No assertion failure");
is($?, 0, "No assertion failure; GH 16865");
}

TODO: {
todo_skip "Test needs -DDEBUGGING", 1 unless $is_debugging_build;
local $::TODO = 'GH 16876';
fresh_perl('$_ = "a"; s{ x | (?{ s{}{x} }) }{}gx;',
{ stderr => 'devnull' });
is($?, 0, "No assertion failure");
is($?, 0, "No assertion failure; GH 16876");
}

TODO: {
todo_skip "Test needs -DDEBUGGING", 1 unless $is_debugging_build;
local $::TODO = 'GH 16952';
fresh_perl('s/d|(?{})!//.$&>0for$0,l..a0,0..0',
{ stderr => 'devnull' });
is($?, 0, "No assertion failure");
is($?, 0, "No assertion failure; GH 16952");
}

TODO: {
local $::TODO = 'GH 16971';
fresh_perl('split(/00|0\G/, "000")',
{ stderr => 'devnull' });
is($?, 0, "No panic");
is($?, 0, "No panic; GH 16971");
}

TODO: {
Expand All @@ -174,16 +175,16 @@ TODO: {
push(@{ $x->{ decide } ? $x->{ not_here } : $x->{ new } }, "mana");
print $x->{ new }[0];
EOF
is($?, 0, "No assertion failure");
is($results, 'mana', 'push on non-existent hash entry from ternary autovivifies array ref');
is($?, 0, "No assertion failure; GH 18669");
is($results, 'mana', 'push on non-existent hash entry from ternary autovivifies array ref; GH 18669');

$results = fresh_perl(<<~'EOF', {});
my $x = { arr => undef };
push(@{ $x->{ decide } ? $x->{ not_here } : $x->{ arr } }, "mana");
print $x->{ arr }[0];
EOF
is($?, 0, "No assertion failure");
is($results, 'mana', 'push on undef hash entry from ternary autovivifies array ref');
is($?, 0, "No assertion failure; GH 18669");
is($results, 'mana', 'push on undef hash entry from ternary autovivifies array ref; GH 18669');

}

Expand Down
Loading