Skip to content

#644 Add invitation_accepted event #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#644 Add invitation_accepted event #648

wants to merge 1 commit into from

Conversation

joshmann35
Copy link
Contributor

@b1conrad let me know if this provides what you need.

@joshmann35 joshmann35 requested a review from b1conrad September 12, 2023 04:03
@joshmann35 joshmann35 linked an issue Sep 12, 2023 that may be closed by this pull request
Raise an event when a DID exchange results in a connection being established #644
Open
@b1conrad
Copy link
Member

b1conrad commented Nov 1, 2023

@joshmann35 Josh, it looks to me like the new event dido:invitation_accepted is raised in two different places, as hoped for, but that the role is "invitee" in both places. I would have expected one of them to be "inviter". What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1conrad b1conrad Awaiting requested review from b1conrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise an event when a DID exchange results in a connection being established
2 participants
@joshmann35 @b1conrad